You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/22 09:00:22 UTC
[GitHub] [superset] dpgaspar commented on a diff in pull request #21724: fix(report): Capture unexpected errors in report screenshots. Fixes #21653
dpgaspar commented on code in PR #21724:
URL: https://github.com/apache/superset/pull/21724#discussion_r1029041367
##########
tests/integration_tests/thumbnails_tests.py:
##########
@@ -62,6 +63,70 @@ def test_get_async_dashboard_screenshot(self):
self.assertEqual(response.getcode(), 202)
+class TestWebDriverScreenshotErrorDetector(SupersetTestCase):
+ @patch("superset.utils.webdriver.WebDriverWait")
+ @patch("superset.utils.webdriver.firefox")
+ @patch("superset.utils.webdriver.find_unexpected_errors")
+ def test_not_call_find_unexpected_errors_if_feature_disabled(
+ self, mock_find_unexpected_errors, mock_firefox, mock_webdriver_wait
+ ):
+ app.config["SCREENSHOT_REPLACE_UNEXPECTED_ERRORS"] = False
+ webdriver_proxy = WebDriverProxy("firefox")
+ user = security_manager.get_user_by_username(
+ app.config["THUMBNAIL_SELENIUM_USER"]
+ )
+ url = get_url_path("Superset.dashboard", dashboard_id_or_slug=1)
+ webdriver_proxy.get_screenshot(url, "grid-container", user=user)
+
+ assert not mock_find_unexpected_errors.called
+
+ @patch("superset.utils.webdriver.WebDriverWait")
+ @patch("superset.utils.webdriver.firefox")
+ @patch("superset.utils.webdriver.find_unexpected_errors")
+ def test_call_find_unexpected_errors_if_feature_enabled(
+ self, mock_find_unexpected_errors, mock_firefox, mock_webdriver_wait
+ ):
+ app.config["SCREENSHOT_REPLACE_UNEXPECTED_ERRORS"] = True
+ webdriver_proxy = WebDriverProxy("firefox")
+ user = security_manager.get_user_by_username(
+ app.config["THUMBNAIL_SELENIUM_USER"]
+ )
+ url = get_url_path("Superset.dashboard", dashboard_id_or_slug=1)
+ webdriver_proxy.get_screenshot(url, "grid-container", user=user)
+
+ assert mock_find_unexpected_errors.called
Review Comment:
please set the config back to it's expected state
`app.config["SCREENSHOT_REPLACE_UNEXPECTED_ERRORS"] = False`
##########
tests/integration_tests/thumbnails_tests.py:
##########
@@ -62,6 +63,70 @@ def test_get_async_dashboard_screenshot(self):
self.assertEqual(response.getcode(), 202)
+class TestWebDriverScreenshotErrorDetector(SupersetTestCase):
+ @patch("superset.utils.webdriver.WebDriverWait")
+ @patch("superset.utils.webdriver.firefox")
+ @patch("superset.utils.webdriver.find_unexpected_errors")
+ def test_not_call_find_unexpected_errors_if_feature_disabled(
+ self, mock_find_unexpected_errors, mock_firefox, mock_webdriver_wait
+ ):
+ app.config["SCREENSHOT_REPLACE_UNEXPECTED_ERRORS"] = False
Review Comment:
If this is the default no need to set it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org