You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by sanjeev n <sa...@citrix.com> on 2014/06/26 13:55:12 UTC

Review Request 23009: Fix for test_portable_ip.py script issues

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23009/
-----------------------------------------------------------

Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.


Bugs: CS-6992
    https://issues.apache.org/jira/browse/CS-6992


Repository: cloudstack-git


Description
-------

1.Currently the test is not reading test data from the config file. So I have made changes in the script to read test data and use it in all the test methods
2.Reading portable ip config values was not proper in getPortableIpRangeServices in lib/common.py so made changes in the library to read portable ip values properly


Diffs
-----

  test/integration/component/test_portable_ip.py b9c9059 
  tools/marvin/marvin/lib/common.py 7b0c7ad 

Diff: https://reviews.apache.org/r/23009/diff/


Testing
-------

Yes


Thanks,

sanjeev n

Re: Review Request 23009: Fix for test_portable_ip.py script issues

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23009/#review46966
-----------------------------------------------------------



test/integration/component/test_portable_ip.py
<https://reviews.apache.org/r/23009/#comment82566>

    Instead to this, can you modify the services() dictionary or move all the data in the services dictionary into test_data.py


- SrikanteswaraRao Talluri


On June 26, 2014, 11:55 a.m., sanjeev n wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23009/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 11:55 a.m.)
> 
> 
> Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CS-6992
>     https://issues.apache.org/jira/browse/CS-6992
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> 1.Currently the test is not reading test data from the config file. So I have made changes in the script to read test data and use it in all the test methods
> 2.Reading portable ip config values was not proper in getPortableIpRangeServices in lib/common.py so made changes in the library to read portable ip values properly
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_portable_ip.py b9c9059 
>   tools/marvin/marvin/lib/common.py 7b0c7ad 
> 
> Diff: https://reviews.apache.org/r/23009/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> sanjeev n
> 
>