You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by bonifaido <gi...@git.apache.org> on 2015/07/07 19:02:05 UTC

[GitHub] curator pull request: Make internalRequeue private

GitHub user bonifaido opened a pull request:

    https://github.com/apache/curator/pull/87

    Make internalRequeue private

    I think this was left public unintentionally.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bonifaido/curator master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/87.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #87
    
----
commit 82036ea957f73d874fc5da47c51e844b6213446f
Author: Nandor Kracser <bo...@gmail.com>
Date:   2015-07-07T17:00:25Z

    Make internalRequeue private

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator pull request: CURATOR-235 LeaderSelector.internalRequeue s...

Posted by madrob <gi...@git.apache.org>.
Github user madrob commented on the pull request:

    https://github.com/apache/curator/pull/87#issuecomment-122707626
  
    Looks like it's been accepted - can one of the committers add a commit with "closes #87" to close the loop on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator pull request: CURATOR-235 LeaderSelector.internalRequeue s...

Posted by bonifaido <gi...@git.apache.org>.
Github user bonifaido commented on the pull request:

    https://github.com/apache/curator/pull/87#issuecomment-121511238
  
    I have closed and reopened it to make it appear in JIRA.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator pull request: Make internalRequeue private

Posted by madrob <gi...@git.apache.org>.
Github user madrob commented on the pull request:

    https://github.com/apache/curator/pull/87#issuecomment-121317261
  
    @bonifaido - This looks like a good catch! Can you create a JIRA issue for this at https://issues.apache.org/jira/browse/CURATOR and then reference that from here? That improves our ability to trace the work back later. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator pull request: CURATOR-235 LeaderSelector.internalRequeue s...

Posted by bonifaido <gi...@git.apache.org>.
GitHub user bonifaido reopened a pull request:

    https://github.com/apache/curator/pull/87

    CURATOR-235 LeaderSelector.internalRequeue should be private

    I think this was left public unintentionally.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bonifaido/curator master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/87.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #87
    
----
commit 82036ea957f73d874fc5da47c51e844b6213446f
Author: Nandor Kracser <bo...@gmail.com>
Date:   2015-07-07T17:00:25Z

    Make internalRequeue private

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator pull request: CURATOR-235 LeaderSelector.internalRequeue s...

Posted by bonifaido <gi...@git.apache.org>.
Github user bonifaido closed the pull request at:

    https://github.com/apache/curator/pull/87


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---