You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by rr...@apache.org on 2019/04/24 06:58:43 UTC

[trafficserver] branch master updated: cppcheck: fixes issue found in proxy/IPAllow.cc

This is an automated email from the ASF dual-hosted git repository.

rrm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 991df53  cppcheck: fixes issue found in proxy/IPAllow.cc
991df53 is described below

commit 991df532eb42d70571056120abb2a5818945cacd
Author: Randall Meyer <ra...@yahoo.com>
AuthorDate: Tue Apr 23 16:42:28 2019 +0800

    cppcheck: fixes issue found in proxy/IPAllow.cc
    
    Variable 'config_file_path' is assigned in constructor body. Consider performing initialization in initialization list.
---
 proxy/IPAllow.cc | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/proxy/IPAllow.cc b/proxy/IPAllow.cc
index 3419258..8adadb7 100644
--- a/proxy/IPAllow.cc
+++ b/proxy/IPAllow.cc
@@ -133,10 +133,7 @@ IpAllow::match(sockaddr const *ip, match_key_t key)
 //   End API functions
 //
 
-IpAllow::IpAllow(const char *config_var)
-{
-  config_file_path = RecConfigReadConfigPath(config_var);
-}
+IpAllow::IpAllow(const char *config_var) : config_file_path(RecConfigReadConfigPath(config_var)) {}
 
 void
 IpAllow::PrintMap(IpMap *map)