You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/30 17:30:58 UTC
[GitHub] [pulsar] lhotari opened a new pull request #14953: [Pulsar SQL] Upgrade Presto version to 334 to support Java 11.0.14.1
lhotari opened a new pull request #14953:
URL: https://github.com/apache/pulsar/pull/14953
Fixes #14951
### Motivation
- Fix compatibility with Java 11.0.14.1
- ensure that airlift versions aren't mixed
### Modifications
- upgrade to Presto version 334 since the incompatiblity with Java 11.0.14.1 is resolved in that version
- enable integration tests for Pulsar SQL again
- prevent mixed airlift library versions by using a BOM
- remove duplication in setting presto and airlift versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dave2wave commented on a change in pull request #14953: [Pulsar SQL] Upgrade Presto version to 334 to support Java 11.0.14.1
Posted by GitBox <gi...@apache.org>.
dave2wave commented on a change in pull request #14953:
URL: https://github.com/apache/pulsar/pull/14953#discussion_r838819406
##########
File path: pom.xml
##########
@@ -156,7 +156,7 @@ flexible messaging model and an intuitive client API.</description>
<hdfs-offload-version3>3.3.1</hdfs-offload-version3>
<json-smart.version>2.4.7</json-smart.version>
<opensearch.version>1.2.4</opensearch.version>
- <presto.version>332</presto.version>
+ <presto.version>334</presto.version>
Review comment:
Since this drops support for JDK8 the documentation needs to be changed as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #14953: [Pulsar SQL] Upgrade Presto version to 334 to support Java 11.0.14.1
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #14953:
URL: https://github.com/apache/pulsar/pull/14953#discussion_r838812401
##########
File path: pom.xml
##########
@@ -156,7 +156,7 @@ flexible messaging model and an intuitive client API.</description>
<hdfs-offload-version3>3.3.1</hdfs-offload-version3>
<json-smart.version>2.4.7</json-smart.version>
<opensearch.version>1.2.4</opensearch.version>
- <presto.version>332</presto.version>
+ <presto.version>334</presto.version>
Review comment:
The reason to upgrade to 334 is to do the minimal change to fix the issue. There might be incompatibilities in newer versions which would have to be addressed.
Yes, we should switch to Trino, but it seems that the PR by @MarvinCai https://github.com/trinodb/trino/pull/8020 hasn't proceeded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #14953: [Pulsar SQL] Upgrade Presto version to 334 to support Java 11.0.14.1
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #14953:
URL: https://github.com/apache/pulsar/pull/14953#discussion_r840513818
##########
File path: pom.xml
##########
@@ -156,7 +156,7 @@ flexible messaging model and an intuitive client API.</description>
<hdfs-offload-version3>3.3.1</hdfs-offload-version3>
<json-smart.version>2.4.7</json-smart.version>
<opensearch.version>1.2.4</opensearch.version>
- <presto.version>332</presto.version>
+ <presto.version>334</presto.version>
Review comment:
#14988 contains a workaround to support both JDK 8 and JDK 11. That is needed for the maintenance branches. For master branch we are going to lift the requirement for the server side components soon, as discussed in the community meeting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #14953: [Pulsar SQL] Upgrade Presto version to 334 to support Java 11.0.14.1
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #14953:
URL: https://github.com/apache/pulsar/pull/14953#discussion_r838803789
##########
File path: pom.xml
##########
@@ -156,7 +156,7 @@ flexible messaging model and an intuitive client API.</description>
<hdfs-offload-version3>3.3.1</hdfs-offload-version3>
<json-smart.version>2.4.7</json-smart.version>
<opensearch.version>1.2.4</opensearch.version>
- <presto.version>332</presto.version>
+ <presto.version>334</presto.version>
Review comment:
We should move to Trino. But actually the plannis to drop this stuff here and move to the Trino project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #14953: [Pulsar SQL] Upgrade Presto version to 334 to support Java 11.0.14.1
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #14953:
URL: https://github.com/apache/pulsar/pull/14953#discussion_r838800184
##########
File path: pom.xml
##########
@@ -156,7 +156,7 @@ flexible messaging model and an intuitive client API.</description>
<hdfs-offload-version3>3.3.1</hdfs-offload-version3>
<json-smart.version>2.4.7</json-smart.version>
<opensearch.version>1.2.4</opensearch.version>
- <presto.version>332</presto.version>
+ <presto.version>334</presto.version>
Review comment:
It's somewhat unrelated to this PR, but these are some very old versions of Presto. 334 was released in May 2020. https://trino.io/docs/current/release/release-334.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14953: [Pulsar SQL] Upgrade Presto version to 334 to support Java 11.0.14.1
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14953:
URL: https://github.com/apache/pulsar/pull/14953#issuecomment-1083458661
I created #14954 with the changes for aligning Airlift library versions by using a BOM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #14953: [Pulsar SQL] Upgrade Presto version to 334 to support Java 11.0.14.1
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #14953:
URL: https://github.com/apache/pulsar/pull/14953#discussion_r838820071
##########
File path: pom.xml
##########
@@ -156,7 +156,7 @@ flexible messaging model and an intuitive client API.</description>
<hdfs-offload-version3>3.3.1</hdfs-offload-version3>
<json-smart.version>2.4.7</json-smart.version>
<opensearch.version>1.2.4</opensearch.version>
- <presto.version>332</presto.version>
+ <presto.version>334</presto.version>
Review comment:
I posted on dev mailing list about this: https://lists.apache.org/thread/3yhz8rql4hwch09728b6myfdq0o37gqj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org