You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/19 10:44:00 UTC
[GitHub] [airflow] jbampton opened a new pull request #12477: Minor HTML fixes
jbampton opened a new pull request #12477:
URL: https://github.com/apache/airflow/pull/12477
- Remove unneeded whitespace from HTML title tag in view source mode
- indent HTML code
- add DOCTYPE
- add lang="en" to the HTML start tag
<img width="175" alt="title-before" src="https://user-images.githubusercontent.com/418747/99655636-afaa2300-2aa7-11eb-8cb4-f1145b050a15.png">
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #12477: Minor HTML fixes
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #12477:
URL: https://github.com/apache/airflow/pull/12477#discussion_r527740789
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -21,11 +21,11 @@
{% from 'appbuilder/loading_dots.html' import loading_dots %}
{% block page_title %}
- {% if search_query %}
+ {%- if search_query -%}
Review comment:
If you are going to do this, do it everywhere, not just in this one page. If you do it to everywhere it should be a separate PR to this one.
Honestly though: this change isn't needed - HTML is not white space sensitive, so this has little benefit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jbampton commented on pull request #12477: Add DOCTYPE and lang attributes to HTML templates.
Posted by GitBox <gi...@apache.org>.
jbampton commented on pull request #12477:
URL: https://github.com/apache/airflow/pull/12477#issuecomment-741875777
Hey @potiuk or @kaxil can you please review 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton merged pull request #12477: Add DOCTYPE and lang attributes to HTML templates.
Posted by GitBox <gi...@apache.org>.
ryanahamilton merged pull request #12477:
URL: https://github.com/apache/airflow/pull/12477
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org