[GitHub] [arrow-datafusion] ozankabak commented on a diff in pull request #5559: improve: support combining multiple grouping expressions

["ozankabak (via GitHub)" <gi...@apache.org>]

ozankabak commented on code in PR #5559:
URL: https://github.com/apache/arrow-datafusion/pull/5559#discussion_r1139325692


##########
datafusion/expr/src/utils.rs:
##########
@@ -69,6 +69,94 @@ pub fn grouping_set_expr_count(group_expr: &[Expr]) -> Result<usize> {
     }
 }
 
+fn powerset<T>(slice: &[T]) -> Vec<Vec<&T>> {

Review Comment:
   There is a power set implementation in [itertools](https://docs.rs/itertools/latest/itertools/trait.Itertools.html#method.powerset), did you consider using it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org