You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/02/22 17:40:27 UTC
[Impala-ASF-CR] IMPALA-8147: part 2: Remove make impala.sh
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12556
Change subject: IMPALA-8147: part 2: Remove make_impala.sh
......................................................................
IMPALA-8147: part 2: Remove make_impala.sh
The previous commit rendered this scripts unused from within
the Impala repository. This removes make_impala.sh and
related scripts entirely.
Testing:
Did a trial run with the -debug_and_release flag to make sure that it
could build all artifacts as expected.
Change-Id: I8688ef9fe651475907cb319eb0b336fd6bef8dfe
---
D bin/make_asan.sh
D bin/make_debug.sh
D bin/make_impala.sh
D bin/make_release.sh
4 files changed, 0 insertions(+), 246 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/12556/1
--
To view, visit http://gerrit.cloudera.org:8080/12556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8688ef9fe651475907cb319eb0b336fd6bef8dfe
Gerrit-Change-Number: 12556
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8147: part 2: Remove make impala.sh
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12556 )
Change subject: IMPALA-8147: part 2: Remove make_impala.sh
......................................................................
Patch Set 1: Code-Review+2
Good to see this cleaned up!
--
To view, visit http://gerrit.cloudera.org:8080/12556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8688ef9fe651475907cb319eb0b336fd6bef8dfe
Gerrit-Change-Number: 12556
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2019 00:09:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8147: part 2: Remove make impala.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12556 )
Change subject: IMPALA-8147: part 2: Remove make_impala.sh
......................................................................
IMPALA-8147: part 2: Remove make_impala.sh
The previous commit rendered this scripts unused from within
the Impala repository. This removes make_impala.sh and
related scripts entirely.
Testing:
Did a trial run with the -debug_and_release flag to make sure that it
could build all artifacts as expected.
Change-Id: I8688ef9fe651475907cb319eb0b336fd6bef8dfe
Reviewed-on: http://gerrit.cloudera.org:8080/12556
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
D bin/make_asan.sh
D bin/make_debug.sh
D bin/make_impala.sh
D bin/make_release.sh
4 files changed, 0 insertions(+), 246 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8688ef9fe651475907cb319eb0b336fd6bef8dfe
Gerrit-Change-Number: 12556
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8147: part 2: Remove make impala.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12556 )
Change subject: IMPALA-8147: part 2: Remove make_impala.sh
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8688ef9fe651475907cb319eb0b336fd6bef8dfe
Gerrit-Change-Number: 12556
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2019 19:57:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8147: part 2: Remove make impala.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12556 )
Change subject: IMPALA-8147: part 2: Remove make_impala.sh
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8688ef9fe651475907cb319eb0b336fd6bef8dfe
Gerrit-Change-Number: 12556
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Mar 2019 00:15:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8147: part 2: Remove make impala.sh
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12556 )
Change subject: IMPALA-8147: part 2: Remove make_impala.sh
......................................................................
Patch Set 1:
ping
--
To view, visit http://gerrit.cloudera.org:8080/12556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8688ef9fe651475907cb319eb0b336fd6bef8dfe
Gerrit-Change-Number: 12556
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 22:16:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8147: part 2: Remove make impala.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12556 )
Change subject: IMPALA-8147: part 2: Remove make_impala.sh
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2214/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8688ef9fe651475907cb319eb0b336fd6bef8dfe
Gerrit-Change-Number: 12556
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Feb 2019 18:16:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8147: part 2: Remove make impala.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12556 )
Change subject: IMPALA-8147: part 2: Remove make_impala.sh
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3890/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8688ef9fe651475907cb319eb0b336fd6bef8dfe
Gerrit-Change-Number: 12556
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2019 19:57:44 +0000
Gerrit-HasComments: No