You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/08 07:41:42 UTC
[GitHub] [apisix-ingress-controller] fgksgf opened a new pull request, #957: Add a pre-check for E2E tests
fgksgf opened a new pull request, #957:
URL: https://github.com/apache/apisix-ingress-controller/pull/957
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [x] CI
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
In #949 we use `ginkgo --focus` to run test cases in parallel, but some newly added cases may not follow the naming convention. So we need to add a pre-check to avoid some E2E cases not running.
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] fgksgf commented on pull request #957: Add a pre-check for E2E tests
Posted by GitBox <gi...@apache.org>.
fgksgf commented on PR #957:
URL: https://github.com/apache/apisix-ingress-controller/pull/957#issuecomment-1092553337
@tao12345666333 plz add a reviewer so that the e2e CI job can run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #957: Add a pre-check for E2E tests
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #957:
URL: https://github.com/apache/apisix-ingress-controller/pull/957#issuecomment-1092935510
> The script can find we missed the prefix in some files
Great!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] fgksgf commented on pull request #957: Add a pre-check for E2E tests
Posted by GitBox <gi...@apache.org>.
fgksgf commented on PR #957:
URL: https://github.com/apache/apisix-ingress-controller/pull/957#issuecomment-1094193757
> Should we add a `check-e2e-name` rule to the Makefile? It might be more convenient
Good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] fgksgf commented on pull request #957: Add a pre-check for E2E tests
Posted by GitBox <gi...@apache.org>.
fgksgf commented on PR #957:
URL: https://github.com/apache/apisix-ingress-controller/pull/957#issuecomment-1092591837
The script can find we missed the prefix in some files:
<img width="704" alt="image" src="https://user-images.githubusercontent.com/26627380/162395820-52b441e9-3ff1-445a-b156-478d08cb4dad.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] fgksgf commented on a diff in pull request #957: Add a pre-check for E2E tests
Posted by GitBox <gi...@apache.org>.
fgksgf commented on code in PR #957:
URL: https://github.com/apache/apisix-ingress-controller/pull/957#discussion_r846895583
##########
Makefile:
##########
@@ -203,3 +204,8 @@ update-gofmt:
### update-all: Update all update- rules.
.PHONY: update-all
update-all: update-codegen update-license update-mdlint update-gofmt
+
+### names-check: Check if e2e test cases' names have the prefix "suite-<suite-name>".
+.PHONY: names-check
Review Comment:
ok, i'll fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #957: Add a pre-check for E2E tests
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #957:
URL: https://github.com/apache/apisix-ingress-controller/pull/957#issuecomment-1092935687
re-run CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #957: Add a pre-check for E2E tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #957:
URL: https://github.com/apache/apisix-ingress-controller/pull/957#issuecomment-1092595049
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/957?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#957](https://codecov.io/gh/apache/apisix-ingress-controller/pull/957?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84706db) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/4bdc9471172a8b1574c61ba5ad5b8fbc4160fc22?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4bdc947) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #957 +/- ##
=======================================
Coverage 31.75% 31.75%
=======================================
Files 72 72
Lines 7935 7935
=======================================
Hits 2520 2520
Misses 5139 5139
Partials 276 276
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/957?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/957?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4bdc947...84706db](https://codecov.io/gh/apache/apisix-ingress-controller/pull/957?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel commented on a diff in pull request #957: Add a pre-check for E2E tests
Posted by GitBox <gi...@apache.org>.
lingsamuel commented on code in PR #957:
URL: https://github.com/apache/apisix-ingress-controller/pull/957#discussion_r846895289
##########
Makefile:
##########
@@ -203,3 +204,8 @@ update-gofmt:
### update-all: Update all update- rules.
.PHONY: update-all
update-all: update-codegen update-license update-mdlint update-gofmt
+
+### names-check: Check if e2e test cases' names have the prefix "suite-<suite-name>".
+.PHONY: names-check
Review Comment:
I think `e2e-names-check` is better because it explicitly indicates that it is related to the e2e test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #957: Add a pre-check for E2E tests
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged PR #957:
URL: https://github.com/apache/apisix-ingress-controller/pull/957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org