You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by martincgg <gi...@git.apache.org> on 2014/04/08 22:59:02 UTC
[GitHub] cordova-cli pull request: CB-6415 [Blackberry] added path.join at ...
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-cli/pull/158
CB-6415 [Blackberry] added path.join at check requirements function
I've tracked down this problem, and I've found it.
Changed path.resolve for custom path, for path.join, is required search
for 'blackberry10' under 'cordova-blackberry' [cloned repository name].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/martincgg/cordova-cli CB-6415
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-cli/pull/158.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #158
----
commit 461a36ca57d6a873ec8384284616eca9a05aafcf
Author: Martin Gonzalez <ma...@gmail.com>
Date: 2014-04-08T20:57:11Z
CB-6415 [Blackberry] added path.join to check req
I've tracked down this problem, and I've found it.
Changed path.resolve for custom path, for path.join, is required search
for 'blackberry10' under 'cordova-blackberry' [cloned repository name].
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-cli pull request: CB-6415 [Blackberry] added path.join at ...
Posted by martincgg <gi...@git.apache.org>.
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-cli/pull/158#issuecomment-39902600
I've tracked down this problem, and I've found the problem.
The custom path in check_requirements function in blackberry10_parser.js, It looks for a custom path, declared into the project, under .cordova/config.js and checks if exists any match with blackberry10.
When a blackberry library is cloned from Github.com, as 'cordova-blackberry', blackberry10 library is located under this cloned repository, I assume that this settlement is because several blackberry platforms can be added here, as it is for 'cordova-windows' that contains windows8 and 7, or as windows-phone that contains wp7 and wp8.
Tracking this problem, I've found that lazy_load.js, joins the url and the platform subdirectory:
https://github.com/apache/cordova-cli/blob/master/src/lazy_load.js#L63
Therefore, the requirements check, it should be handle under the same conditions.
Adding path.join, it only will add the custom_path + 'blackberry10' ---> lib name and it will normalize the path as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-cli pull request: CB-6415 [Blackberry] added path.join at ...
Posted by martincgg <gi...@git.apache.org>.
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-cli/pull/158#issuecomment-42867986
Excellent, Thanks @bryanhiggins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-cli pull request: CB-6415 [Blackberry] added path.join at ...
Posted by martincgg <gi...@git.apache.org>.
Github user martincgg closed the pull request at:
https://github.com/apache/cordova-cli/pull/158
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-cli pull request: CB-6415 [Blackberry] added path.join at ...
Posted by bryanhiggins <gi...@git.apache.org>.
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-cli/pull/158#issuecomment-42867675
I applied this change to cordova-lib since this is where the parser now lives
https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=commit;h=5e4a99218c361c9e8ff339a4fe89dcf2bc31cf99
@martincgg this PR can be closed. thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---