You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2017/03/23 22:13:07 UTC
Review Request 57895: upgrade frontend-maven-plugin to latest >= 1.3
to make use of ignore proxy feature
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57895/
-----------------------------------------------------------
Review request for Ambari, Richard Zang, Sumit Mohanty, and Yusaku Sako.
Bugs: AMBARI-20549
https://issues.apache.org/jira/browse/AMBARI-20549
Repository: ambari
Description
-------
frontend-maven-plugin inherits maven settings.xml proxy values, in latest version >=1.3 proxy settings can be ignore by setting 'npmInheritsProxyConfigFromMaven' to 'false'
REF: https://github.com/eirslett/frontend-maven-plugin/pull/387
The following files contain the plugin
{noformat}
ambari-admin/pom.xml
ambari-web/pom.xml
contrib/views/capacity-scheduler/pom.xml
contrib/views/files/pom.xml
contrib/views/hawq/pom.xml
contrib/views/hive-next/pom.xml
contrib/views/hive20/pom.xml
contrib/views/hueambarimigration/pom.xml
contrib/views/jobs/pom.xml
contrib/views/pig/pom.xml
contrib/views/wfmanager/pom.xml
contrib/views/wfmanager/src/main/resources/ui/pom.xml
{noformat}
Diffs
-----
ambari-admin/pom.xml 97d5fd4
ambari-web/pom.xml 6c84688
contrib/views/capacity-scheduler/pom.xml e18514c
contrib/views/files/pom.xml 663615a
contrib/views/hawq/pom.xml c62af56
contrib/views/hive-next/pom.xml fd85a50
contrib/views/hive20/pom.xml 0d97bbd
contrib/views/hueambarimigration/pom.xml 891876d
contrib/views/jobs/pom.xml 3475191
contrib/views/pig/pom.xml d7d2de9
contrib/views/wfmanager/pom.xml cc48ef2
contrib/views/wfmanager/src/main/resources/ui/pom.xml 8bdb332
Diff: https://reviews.apache.org/r/57895/diff/1/
Testing
-------
verified that the build passes with the patch:
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ........................................ SUCCESS [ 53.095 s]
[INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.012 s]
[INFO] Ambari Web ......................................... SUCCESS [02:33 min]
[INFO] Ambari Views ....................................... SUCCESS [ 2.499 s]
[INFO] Ambari Admin View .................................. SUCCESS [ 52.879 s]
[INFO] utility ............................................ SUCCESS [ 0.542 s]
[INFO] ambari-metrics ..................................... SUCCESS [ 0.462 s]
[INFO] Ambari Metrics Common .............................. SUCCESS [ 4.866 s]
[INFO] Ambari Metrics Hadoop Sink ......................... SUCCESS [ 2.993 s]
[INFO] Ambari Metrics Flume Sink .......................... SUCCESS [ 1.739 s]
[INFO] Ambari Metrics Kafka Sink .......................... SUCCESS [ 4.900 s]
[INFO] Ambari Metrics Storm Sink .......................... SUCCESS [ 5.139 s]
[INFO] Ambari Metrics Storm Sink (Legacy) ................. SUCCESS [ 3.180 s]
[INFO] Ambari Metrics Collector ........................... SUCCESS [ 56.026 s]
[INFO] Ambari Metrics Monitor ............................. SUCCESS [ 12.811 s]
[INFO] Ambari Metrics Grafana ............................. SUCCESS [ 6.838 s]
[INFO] Ambari Metrics Assembly ............................ SUCCESS [05:46 min]
[INFO] Ambari Server ...................................... SUCCESS [08:29 min]
[INFO] Ambari Functional Tests ............................ SUCCESS [ 11.808 s]
[INFO] Ambari Agent ....................................... SUCCESS [02:26 min]
[INFO] Ambari Client ...................................... SUCCESS [ 0.099 s]
[INFO] Ambari Python Client ............................... SUCCESS [ 5.032 s]
[INFO] Ambari Groovy Client ............................... SUCCESS [ 5.661 s]
[INFO] Ambari Shell ....................................... SUCCESS [ 0.022 s]
[INFO] Ambari Python Shell ................................ SUCCESS [ 0.993 s]
[INFO] Ambari Groovy Shell ................................ SUCCESS [ 3.024 s]
[INFO] ambari-logsearch ................................... SUCCESS [ 0.243 s]
[INFO] Ambari Logsearch Appender .......................... SUCCESS [ 0.257 s]
[INFO] Ambari Logsearch Portal ............................ SUCCESS [ 57.573 s]
[INFO] Ambari Logsearch Log Feeder ........................ SUCCESS [ 12.128 s]
[INFO] Ambari Logsearch Solr Client ....................... SUCCESS [ 4.540 s]
[INFO] Ambari Infra Solr Plugin ........................... SUCCESS [ 1.887 s]
[INFO] Ambari Logsearch Assembly .......................... SUCCESS [ 0.099 s]
[INFO] Ambari Logsearch Integration Test .................. SUCCESS [ 6.255 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 24:37 min
[INFO] Finished at: 2017-03-23T14:43:59-07:00
[INFO] Final Memory: 233M/658M
[INFO] ------------------------------------------------------------------------
Thanks,
Jaimin Jetly
Re: Review Request 57895: upgrade frontend-maven-plugin to latest >=
1.3 to make use of ignore proxy feature
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57895/#review169935
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On March 23, 2017, 10:13 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57895/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 10:13 p.m.)
>
>
> Review request for Ambari, Richard Zang, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-20549
> https://issues.apache.org/jira/browse/AMBARI-20549
>
>
> Repository: ambari
>
>
> Description
> -------
>
> frontend-maven-plugin inherits maven settings.xml proxy values, in latest version >=1.3 proxy settings can be ignore by setting 'npmInheritsProxyConfigFromMaven' to 'false'
> REF: https://github.com/eirslett/frontend-maven-plugin/pull/387
> The following files contain the plugin
> {noformat}
> ambari-admin/pom.xml
> ambari-web/pom.xml
> contrib/views/capacity-scheduler/pom.xml
> contrib/views/files/pom.xml
> contrib/views/hawq/pom.xml
> contrib/views/hive-next/pom.xml
> contrib/views/hive20/pom.xml
> contrib/views/hueambarimigration/pom.xml
> contrib/views/jobs/pom.xml
> contrib/views/pig/pom.xml
> contrib/views/wfmanager/pom.xml
> contrib/views/wfmanager/src/main/resources/ui/pom.xml
> {noformat}
>
>
> Diffs
> -----
>
> ambari-admin/pom.xml 97d5fd4
> ambari-web/pom.xml 6c84688
> contrib/views/capacity-scheduler/pom.xml e18514c
> contrib/views/files/pom.xml 663615a
> contrib/views/hawq/pom.xml c62af56
> contrib/views/hive-next/pom.xml fd85a50
> contrib/views/hive20/pom.xml 0d97bbd
> contrib/views/hueambarimigration/pom.xml 891876d
> contrib/views/jobs/pom.xml 3475191
> contrib/views/pig/pom.xml d7d2de9
> contrib/views/wfmanager/pom.xml cc48ef2
> contrib/views/wfmanager/src/main/resources/ui/pom.xml 8bdb332
>
>
> Diff: https://reviews.apache.org/r/57895/diff/1/
>
>
> Testing
> -------
>
> verified that the build passes with the patch:
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ........................................ SUCCESS [ 53.095 s]
> [INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.012 s]
> [INFO] Ambari Web ......................................... SUCCESS [02:33 min]
> [INFO] Ambari Views ....................................... SUCCESS [ 2.499 s]
> [INFO] Ambari Admin View .................................. SUCCESS [ 52.879 s]
> [INFO] utility ............................................ SUCCESS [ 0.542 s]
> [INFO] ambari-metrics ..................................... SUCCESS [ 0.462 s]
> [INFO] Ambari Metrics Common .............................. SUCCESS [ 4.866 s]
> [INFO] Ambari Metrics Hadoop Sink ......................... SUCCESS [ 2.993 s]
> [INFO] Ambari Metrics Flume Sink .......................... SUCCESS [ 1.739 s]
> [INFO] Ambari Metrics Kafka Sink .......................... SUCCESS [ 4.900 s]
> [INFO] Ambari Metrics Storm Sink .......................... SUCCESS [ 5.139 s]
> [INFO] Ambari Metrics Storm Sink (Legacy) ................. SUCCESS [ 3.180 s]
> [INFO] Ambari Metrics Collector ........................... SUCCESS [ 56.026 s]
> [INFO] Ambari Metrics Monitor ............................. SUCCESS [ 12.811 s]
> [INFO] Ambari Metrics Grafana ............................. SUCCESS [ 6.838 s]
> [INFO] Ambari Metrics Assembly ............................ SUCCESS [05:46 min]
> [INFO] Ambari Server ...................................... SUCCESS [08:29 min]
> [INFO] Ambari Functional Tests ............................ SUCCESS [ 11.808 s]
> [INFO] Ambari Agent ....................................... SUCCESS [02:26 min]
> [INFO] Ambari Client ...................................... SUCCESS [ 0.099 s]
> [INFO] Ambari Python Client ............................... SUCCESS [ 5.032 s]
> [INFO] Ambari Groovy Client ............................... SUCCESS [ 5.661 s]
> [INFO] Ambari Shell ....................................... SUCCESS [ 0.022 s]
> [INFO] Ambari Python Shell ................................ SUCCESS [ 0.993 s]
> [INFO] Ambari Groovy Shell ................................ SUCCESS [ 3.024 s]
> [INFO] ambari-logsearch ................................... SUCCESS [ 0.243 s]
> [INFO] Ambari Logsearch Appender .......................... SUCCESS [ 0.257 s]
> [INFO] Ambari Logsearch Portal ............................ SUCCESS [ 57.573 s]
> [INFO] Ambari Logsearch Log Feeder ........................ SUCCESS [ 12.128 s]
> [INFO] Ambari Logsearch Solr Client ....................... SUCCESS [ 4.540 s]
> [INFO] Ambari Infra Solr Plugin ........................... SUCCESS [ 1.887 s]
> [INFO] Ambari Logsearch Assembly .......................... SUCCESS [ 0.099 s]
> [INFO] Ambari Logsearch Integration Test .................. SUCCESS [ 6.255 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:37 min
> [INFO] Finished at: 2017-03-23T14:43:59-07:00
> [INFO] Final Memory: 233M/658M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jaimin Jetly
>
>