You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/12 13:54:32 UTC
[GitHub] [doris] adonis0147 commented on a diff in pull request #15876: [fix](terminal) remove echo database passwd
adonis0147 commented on code in PR #15876:
URL: https://github.com/apache/doris/pull/15876#discussion_r1068146932
##########
tools/ssb-tools/bin/gen-ssb-data.sh:
##########
@@ -126,7 +126,7 @@ date
cd -
# move data to $SSB_DATA_DIR
-mv "${SSB_DBGEN_DIR}"/*.tbl* "${SSB_DATA_DIR}/"
+mv "${SSB_DBGEN_DIR}"*.tbl* "${SSB_DATA_DIR}/"
Review Comment:
`"${SSB_DBGEN_DIR}"*.tbl*` looks weird. I think the original one is better. Maybe we should remove the `/` from the assignment of `SSB_DBGEN_DIR` in [#L32](https://github.com/apache/doris/blob/f8f4cba64f8e75910b0a447c1813a2203e5c99b4/tools/ssb-tools/bin/gen-ssb-data.sh#L32).
##########
tools/ssb-tools/bin/gen-ssb-data.sh:
##########
@@ -126,7 +126,7 @@ date
cd -
# move data to $SSB_DATA_DIR
-mv "${SSB_DBGEN_DIR}"/*.tbl* "${SSB_DATA_DIR}/"
+mv "${SSB_DBGEN_DIR}"*.tbl* "${SSB_DATA_DIR}/"
# check data
-du -sh "${SSB_DATA_DIR}"/*.tbl*
+du -sh "${SSB_DATA_DIR}"*.tbl*
Review Comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org