svn commit: r1361123 - /subversion/trunk/subversion/libsvn_subr/simple_providers.c

[rh...@apache.org]

Author: rhuijben
Date: Fri Jul 13 09:23:36 2012
New Revision: 1361123

URL: http://svn.apache.org/viewvc?rev=1361123&view=rev
Log:
Fix potential situation in which credentials are not saved to cache when
they have changed.

If cached username and new username differ but passwords are the same,
'need_to_save' flag will be overwritten to FALSE, and new credentials
fill not be saved.

* subversion/libsvn_subr/simple_providers.c
(svn_auth__simple_creds_cache_get): Stop setting need_to_save to FALSE.

Patch by: Dmitry Pavlenko <pavlenko{_AT_}tmatesoft.com>

Modified:
    subversion/trunk/subversion/libsvn_subr/simple_providers.c

Modified: subversion/trunk/subversion/libsvn_subr/simple_providers.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/simple_providers.c?rev=1361123&r1=1361122&r2=1361123&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/simple_providers.c (original)
+++ subversion/trunk/subversion/libsvn_subr/simple_providers.c Fri Jul 13 09:23:36 2012
@@ -202,9 +202,7 @@ svn_auth__simple_creds_cache_get(void **
             }
           else
             {
-              if (0 == strcmp(default_username, username))
-                need_to_save = FALSE;
-              else
+              if (strcmp(default_username, username) != 0)
                 need_to_save = TRUE;
             }
         }
@@ -226,9 +224,7 @@ svn_auth__simple_creds_cache_get(void **
                 }
               else
                 {
-                  if (0 == strcmp(default_password, password))
-                    need_to_save = FALSE;
-                  else
+                  if (strcmp(default_password, password) != 0)
                     need_to_save = TRUE;
                 }
             }