You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/06/24 20:17:03 UTC

[GitHub] [daffodil] mbeckerle commented on a change in pull request #490: Unsupported characterset

mbeckerle commented on a change in pull request #490:
URL: https://github.com/apache/daffodil/pull/490#discussion_r658253210



##########
File path: daffodil-test/src/test/scala/org/apache/daffodil/section10/representation_properties/encodings.tdml
##########
@@ -0,0 +1,275 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--

Review comment:
       Wow, I'm not the only guy who uses emacs? How great is that?  :-) 
   
   @susmita-m145  This team is *really good* and I depend on this team as well as our automated continuous-integration runs, to catch things. I have fallen into the trap of running all the tests, seeing success, then trying to slide in one more little inconsequential change, like just updating a code-comment, and then pushing it, only to find *blam* I made a typo and things are broken. 
   
   As you are one of the people working on EBCDIC/IBM stuff, I am also very interested in your use case for Daffodil and the priority you give to finishing the tickets like the P, V text number pattern features (for COBOL data) etc. 
   
   I am hoping you have a bit more time to push this PR over the finish line. Thanks -mikeb




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org