You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/12/01 01:34:42 UTC
Re: Review Request 63823: Initialized and subscribed storage local
resource provider.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63823/
-----------------------------------------------------------
(Updated Dec. 1, 2017, 1:34 a.m.)
Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Jan Schlicht.
Changes
-------
Don't fatal after `driver->send(..)` fails.
Bugs: MESOS-8032
https://issues.apache.org/jira/browse/MESOS-8032
Repository: mesos
Description
-------
This patch validates `ResourceProviderInfo` for storage local resource
providers upon creation. During initialization, the storage local
resource provider first tries to recover its ID of the last session
through reading the actual path linked by
`<work_dir>/meta/resource_providers/<type>/<name>/latest`,
then subscribe to the agent's resource provider manager.
This patch is split from https://reviews.apache.org/r/63021/.
Diffs (updated)
-----
src/resource_provider/storage/provider.cpp f586afc256fbcb2f2bf2451ffb7e7ba1d59cfa78
Diff: https://reviews.apache.org/r/63823/diff/7/
Changes: https://reviews.apache.org/r/63823/diff/6-7/
Testing
-------
make
Thanks,
Chun-Hung Hsiao
Re: Review Request 63823: Initialized and subscribed storage local
resource provider.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63823/#review192597
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 1, 2017, 1:34 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63823/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 1:34 a.m.)
>
>
> Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-8032
> https://issues.apache.org/jira/browse/MESOS-8032
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch validates `ResourceProviderInfo` for storage local resource
> providers upon creation. During initialization, the storage local
> resource provider first tries to recover its ID of the last session
> through reading the actual path linked by
> `<work_dir>/meta/resource_providers/<type>/<name>/latest`,
> then subscribe to the agent's resource provider manager.
>
> This patch is split from https://reviews.apache.org/r/63021/.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp f586afc256fbcb2f2bf2451ffb7e7ba1d59cfa78
>
>
> Diff: https://reviews.apache.org/r/63823/diff/7/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 63823: Initialized and subscribed storage local
resource provider.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63823/#review192440
-----------------------------------------------------------
src/resource_provider/storage/provider.cpp
Lines 245 (patched)
<https://reviews.apache.org/r/63823/#comment270596>
Who is going to delete `StorageLocalResourceProvider` so that we can force a disconnection to the RP manager?
You can workaround it by reset the driver here. But how the local rp daemon detect that an RP has failed?
src/resource_provider/storage/provider.cpp
Lines 260 (patched)
<https://reviews.apache.org/r/63823/#comment270597>
why not return a failure if `realpath.isError`?
- Jie Yu
On Dec. 1, 2017, 1:34 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63823/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 1:34 a.m.)
>
>
> Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-8032
> https://issues.apache.org/jira/browse/MESOS-8032
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch validates `ResourceProviderInfo` for storage local resource
> providers upon creation. During initialization, the storage local
> resource provider first tries to recover its ID of the last session
> through reading the actual path linked by
> `<work_dir>/meta/resource_providers/<type>/<name>/latest`,
> then subscribe to the agent's resource provider manager.
>
> This patch is split from https://reviews.apache.org/r/63021/.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp f586afc256fbcb2f2bf2451ffb7e7ba1d59cfa78
>
>
> Diff: https://reviews.apache.org/r/63823/diff/7/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>