[GitHub] [incubator-mxnet] zheng-da commented on a change in pull request #14393: [MXNET-1352] Allow dynamic shape in while_loop and if conditionals

[GitBox <gi...@apache.org>]

zheng-da commented on a change in pull request #14393: [MXNET-1352] Allow dynamic shape in while_loop and if conditionals
URL: https://github.com/apache/incubator-mxnet/pull/14393#discussion_r282211403
 
 

 ##########
 File path: src/executor/graph_executor.cc
 ##########
 @@ -811,6 +876,7 @@ Executor* GraphExecutor::Reshape(const bool partial_shaping,
   }
   g = InferShape(std::move(g), std::move(arg_shapes), "__shape__");
   if (g.GetAttr<size_t>("shape_num_unknown_nodes") != 0U) {
+    this->is_dynamic_ = true;
     HandleInferShapeError(num_forward_inputs_, g.indexed_graph(),
                           g.GetAttr<mxnet::ShapeVector>("shape"));
 
 Review comment:
   remove this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services