You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "jtibshirani (via GitHub)" <gi...@apache.org> on 2023/02/13 22:08:38 UTC
[GitHub] [lucene] jtibshirani opened a new pull request, #12146: Simplify max score for kNN vector queries
jtibshirani opened a new pull request, #12146:
URL: https://github.com/apache/lucene/pull/12146
The helper class DocAndScoreQuery implements advanceShallow to help skip
non-competitive documents. This method doesn't actually keep track of where it
has advanced, which means it can do extra work.
Overall the complexity here didn't seem worth it, given the low cost of
collecting matching kNN docs. This PR switches to a simple approach, which uses
a fixed upper bound on the max score.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jtibshirani commented on pull request #12146: Simplify max score for kNN vector queries
Posted by "jtibshirani (via GitHub)" <gi...@apache.org>.
jtibshirani commented on PR #12146:
URL: https://github.com/apache/lucene/pull/12146#issuecomment-1433647800
Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jtibshirani merged pull request #12146: Simplify max score for kNN vector queries
Posted by "jtibshirani (via GitHub)" <gi...@apache.org>.
jtibshirani merged PR #12146:
URL: https://github.com/apache/lucene/pull/12146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jtibshirani commented on pull request #12146: Simplify max score for kNN vector queries
Posted by "jtibshirani (via GitHub)" <gi...@apache.org>.
jtibshirani commented on PR #12146:
URL: https://github.com/apache/lucene/pull/12146#issuecomment-1428789703
The context: I've been testing out an AI code assistant, and I asked it if there were any bugs in `AbstractKnnVectorQuery`. It pointed out that "'advanceShallow' should move the 'upTo' field like 'nextDoc' does" ... which didn't seem right, but made me realize this logic looked funny.
I'm not an expert in the doc skipping code, and had trouble fully understanding the method contracts. So let me know if this is off!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org