[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42722: [SPARK-45007][INFRA] Fix merged pull requests resolution

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #42722:
URL: https://github.com/apache/spark/pull/42722#discussion_r1308983211


##########
dev/merge_spark_pr.py:
##########
@@ -611,9 +611,9 @@ def main():
     pr_repo_desc = "%s/%s" % (user_login, base_ref)
 
     # Merged pull requests don't appear as merged in the GitHub API;
-    # Instead, they're closed by asfgit.
+    # Instead, they're closed by committers.
     merge_commits = [
-        e for e in pr_events if e["actor"]["login"] == "asfgit" and e["event"] == "closed"
+        e for e in pr_events if e["event"] == "closed" and e["commit_id"] is not None
     ]

Review Comment:
   Could you fix Python linter failure by running `dev/reformat-python`, @yaooqinn ? It seems to ask to change like the following.
   ```python
   -    merge_commits = [
   -        e for e in pr_events if e["event"] == "closed" and e["commit_id"] is not None
   -    ]
   +    merge_commits = [e for e in pr_events if e["event"] == "closed" and e["commit_id"] is not None]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org