You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by jiangxb1987 <gi...@git.apache.org> on 2018/08/01 17:47:45 UTC

[GitHub] spark pull request #21898: [SPARK-24817][Core] Implement BarrierTaskContext....

Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21898#discussion_r206972303
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskScheduler.scala ---
    @@ -61,6 +61,9 @@ private[spark] trait TaskScheduler {
        */
       def killTaskAttempt(taskId: Long, interruptThread: Boolean, reason: String): Boolean
     
    +  // Kill all the running task attempts in a stage.
    +  def killAllTaskAttempts(stageId: Int, interruptThread: Boolean, reason: String): Unit
    --- End diff --
    
    Submitted #21943 , however, still need this here until #21943  is merged, because otherwise the test cases shall fail.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org