You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2018/04/07 23:33:16 UTC

Review Request 66495: RANGER-2061: Add policy engine support to get summary user and group ACLs for a resource

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66495/
-----------------------------------------------------------

Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy.


Bugs: RANGER-2061
    https://issues.apache.org/jira/browse/RANGER-2061


Repository: ranger


Description
-------

It is useful to be able to retrieve user and group based Access Control Lists from Ranger policies for a given resource. When, given the set of Ranger policies,  permission cannot be determined statically, permission will be flagged as CONDITIONAL.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java 5febf956d 
  agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java f6e462ccc 
  agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerContextEnricher.java 9d0b9852b 
  agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java d5d14a22d 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestImpl.java 3b06f423f 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java 313a8a96f 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java 5510f6ea3 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineOptions.java 2bbdcede5 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceACLs.java PRE-CREATION 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java 4e6ca2f62 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyItemEvaluator.java cd7c3c1c4 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java c539cc0dc 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java 613a0017d 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyItemEvaluator.java bd61cfd0a 
  agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContext.java PRE-CREATION 
  agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContextListener.java PRE-CREATION 
  agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 725ed74d0 
  agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyACLs.java PRE-CREATION 
  agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 325626a58 
  agents-common/src/test/resources/log4j.xml 926f47ced 
  agents-common/src/test/resources/policyengine/ACLResourceTags.json PRE-CREATION 
  agents-common/src/test/resources/policyengine/test_aclprovider_default.json PRE-CREATION 
  agents-common/src/test/resources/policyengine/test_policyengine_tag_hive.json 11f31e317 


Diff: https://reviews.apache.org/r/66495/diff/1/


Testing
-------

Developed and ran unit tests.


Thanks,

Abhay Kulkarni


Re: Review Request 66495: RANGER-2061: Add policy engine support to get summary user and group ACLs for a resource

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66495/#review200755
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On April 8, 2018, 7:52 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66495/
> -----------------------------------------------------------
> 
> (Updated April 8, 2018, 7:52 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2061
>     https://issues.apache.org/jira/browse/RANGER-2061
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> It is useful to be able to retrieve user and group based Access Control Lists from Ranger policies for a given resource. When, given the set of Ranger policies,  permission cannot be determined statically, permission will be flagged as CONDITIONAL.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java 5febf956d 
>   agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java f6e462ccc 
>   agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerContextEnricher.java 9d0b9852b 
>   agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java d5d14a22d 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestImpl.java 3b06f423f 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java 313a8a96f 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java 5510f6ea3 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineOptions.java 2bbdcede5 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceACLs.java PRE-CREATION 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java 4e6ca2f62 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyItemEvaluator.java cd7c3c1c4 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java c539cc0dc 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java 613a0017d 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyItemEvaluator.java bd61cfd0a 
>   agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContext.java PRE-CREATION 
>   agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContextListener.java PRE-CREATION 
>   agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 725ed74d0 
>   agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyACLs.java PRE-CREATION 
>   agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 325626a58 
>   agents-common/src/test/resources/log4j.xml 926f47ced 
>   agents-common/src/test/resources/policyengine/ACLResourceTags.json PRE-CREATION 
>   agents-common/src/test/resources/policyengine/test_aclprovider_default.json PRE-CREATION 
>   agents-common/src/test/resources/policyengine/test_policyengine_tag_hive.json 11f31e317 
> 
> 
> Diff: https://reviews.apache.org/r/66495/diff/2/
> 
> 
> Testing
> -------
> 
> Developed and ran unit tests.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Re: Review Request 66495: RANGER-2061: Add policy engine support to get summary user and group ACLs for a resource

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66495/
-----------------------------------------------------------

(Updated April 8, 2018, 7:52 p.m.)


Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy.


Bugs: RANGER-2061
    https://issues.apache.org/jira/browse/RANGER-2061


Repository: ranger


Description
-------

It is useful to be able to retrieve user and group based Access Control Lists from Ranger policies for a given resource. When, given the set of Ranger policies,  permission cannot be determined statically, permission will be flagged as CONDITIONAL.


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java 5febf956d 
  agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java f6e462ccc 
  agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerContextEnricher.java 9d0b9852b 
  agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java d5d14a22d 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestImpl.java 3b06f423f 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java 313a8a96f 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java 5510f6ea3 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineOptions.java 2bbdcede5 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceACLs.java PRE-CREATION 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java 4e6ca2f62 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyItemEvaluator.java cd7c3c1c4 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java c539cc0dc 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java 613a0017d 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyItemEvaluator.java bd61cfd0a 
  agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContext.java PRE-CREATION 
  agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContextListener.java PRE-CREATION 
  agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 725ed74d0 
  agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyACLs.java PRE-CREATION 
  agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 325626a58 
  agents-common/src/test/resources/log4j.xml 926f47ced 
  agents-common/src/test/resources/policyengine/ACLResourceTags.json PRE-CREATION 
  agents-common/src/test/resources/policyengine/test_aclprovider_default.json PRE-CREATION 
  agents-common/src/test/resources/policyengine/test_policyengine_tag_hive.json 11f31e317 


Diff: https://reviews.apache.org/r/66495/diff/2/

Changes: https://reviews.apache.org/r/66495/diff/1-2/


Testing
-------

Developed and ran unit tests.


Thanks,

Abhay Kulkarni