[jira] [Updated] (HIVE-25926) Move all logging from AcidMetricService to AcidMetricLogger

["Viktor Csomor (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-25926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Viktor Csomor updated HIVE-25926:
---------------------------------
    Description: 
Some logging is left over in AcidMetricService (which used to both log errors/warnings and emit metrics, and now just emits metrics). Logging should be in the AcidMetricLogger as much as possible. Stragglers left over in AcidMetricService:
 * compaction_oldest_enqueue_age_in_sec
 * COMPACTOR_FAILED_COMPACTION_RATIO_THRESHOLD logging
 * Multiple Compaction Worker versions (in method: detectMultipleWorkerVersions)

  was:
Instead of calculating the age on the Database side for the {{oldest_ready_for_cleaning_age_in_sec}} we can calculate it in the AcidMetricsService. At the moment the {{CQ_COMMIT_TIME}} is not exposed in the {{ShowCompactResponse}} therefore the calculation happens in the db query.

It has to be assessed whether it worth to expose this field or not? 


> Move all logging from AcidMetricService to AcidMetricLogger
> -----------------------------------------------------------
>
>                 Key: HIVE-25926
>                 URL: https://issues.apache.org/jira/browse/HIVE-25926
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 4.0.0
>            Reporter: Viktor Csomor
>            Assignee: Viktor Csomor
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>
> Some logging is left over in AcidMetricService (which used to both log errors/warnings and emit metrics, and now just emits metrics). Logging should be in the AcidMetricLogger as much as possible. Stragglers left over in AcidMetricService:
>  * compaction_oldest_enqueue_age_in_sec
>  * COMPACTOR_FAILED_COMPACTION_RATIO_THRESHOLD logging
>  * Multiple Compaction Worker versions (in method: detectMultipleWorkerVersions)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)