You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "cwrothrock (via GitHub)" <gi...@apache.org> on 2023/05/19 21:21:25 UTC
[GitHub] [beam] cwrothrock opened a new pull request, #26798: Add boilerplate Java21 security properties support for Java SDK containers
cwrothrock opened a new pull request, #26798:
URL: https://github.com/apache/beam/pull/26798
Changes:
* Add Java version-specific override to the security property jdk.tls.disabledAlgorithms via a container image meta option. Noting that the property value is derived from openjdk 21-ea and this action does not reflect that a Beam SDK container officially supporting Java 21 is available.
See #24619 for more historical context.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [x] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn merged pull request #26798: Add boilerplate Java21 security properties support for Java SDK containers
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #26798:
URL: https://github.com/apache/beam/pull/26798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] cwrothrock commented on pull request #26798: Add boilerplate Java21 security properties support for Java SDK containers
Posted by "cwrothrock (via GitHub)" <gi...@apache.org>.
cwrothrock commented on PR #26798:
URL: https://github.com/apache/beam/pull/26798#issuecomment-1557145263
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] cwrothrock commented on pull request #26798: Add boilerplate Java21 security properties support for Java SDK containers
Posted by "cwrothrock (via GitHub)" <gi...@apache.org>.
cwrothrock commented on PR #26798:
URL: https://github.com/apache/beam/pull/26798#issuecomment-1611897708
Yes this can be merged, as the existence of the folder/files should not affect any container builds since there is no gradle or dockerfile for Java 21.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26798: Add boilerplate Java21 security properties support for Java SDK containers
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26798:
URL: https://github.com/apache/beam/pull/26798#issuecomment-1611882333
@cwrothrock is this ready to merge or wait until Java 21 official release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26798: Add boilerplate Java21 security properties support for Java SDK containers
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26798:
URL: https://github.com/apache/beam/pull/26798#issuecomment-1555311681
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @robertwb for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] cwrothrock commented on pull request #26798: Add boilerplate Java21 security properties support for Java SDK containers
Posted by "cwrothrock (via GitHub)" <gi...@apache.org>.
cwrothrock commented on PR #26798:
URL: https://github.com/apache/beam/pull/26798#issuecomment-1557597965
R: @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26798: Add boilerplate Java21 security properties support for Java SDK containers
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26798:
URL: https://github.com/apache/beam/pull/26798#issuecomment-1557599893
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org