[GitHub] [cassandra] adelapena commented on a change in pull request #1440: CASSANDRA-17353 trunk: Flatten guardrails config

[GitBox <gi...@apache.org>]

adelapena commented on a change in pull request #1440:
URL: https://github.com/apache/cassandra/pull/1440#discussion_r801578947



##########
File path: src/java/org/apache/cassandra/config/Config.java
##########
@@ -725,6 +723,25 @@ public static void setClientMode(boolean clientMode)
     public volatile SubnetGroups client_error_reporting_exclusions = new SubnetGroups();
     public volatile SubnetGroups internode_error_reporting_exclusions = new SubnetGroups();
 
+    public static final int DISABLED_GUARDRAIL = -1;
+    public volatile boolean guardrails_enabled = false;
+    public volatile int keyspaces_warn_threshold = DISABLED_GUARDRAIL;
+    public volatile int keyspaces_abort_threshold = DISABLED_GUARDRAIL;
+    public volatile int tables_warn_threshold = DISABLED_GUARDRAIL;
+    public volatile int tables_abort_threshold = DISABLED_GUARDRAIL;

Review comment:
       The warning thresholds replace the previous properties `table_count_warn_threshold` and `keyspace_count_warn_threshold`, which were deprecated by CASSANDRA-17195. I think that the `_count_` part of the name isn't used in any other property on the file. I'd say that the new names seem more in line with other property names such as `tombstone_warn_threshold`, `cached_rows_warn_threshold`, `unlogged_batch_across_partitions_warn_threshold`, etc. 
   
   In any case, I guess we'll revisit naming before the next release.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org