[GitHub] [incubator-doris] gaodayue commented on a change in pull request #3405: [Profile] Make running profile clearer and more intuitive to improve usability

[GitBox <gi...@apache.org>]

gaodayue commented on a change in pull request #3405:
URL: https://github.com/apache/incubator-doris/pull/3405#discussion_r416464063



##########
File path: be/src/exec/exec_node.cpp
##########
@@ -172,15 +172,13 @@ Status ExecNode::prepare(RuntimeState* state) {
     DCHECK(_runtime_profile.get() != NULL);
     _rows_returned_counter =
         ADD_COUNTER(_runtime_profile, "RowsReturned", TUnit::UNIT);
-    _memory_used_counter =
-        ADD_COUNTER(_runtime_profile, "MemoryUsed", TUnit::BYTES);

Review comment:
       You'd better remove this field if it's not used. Btw, `_memory_used_counter` seems to be used by `HashJoinNode::close`, is it really ok to remove it?
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org