[jira] [Comment Edited] (OOZIE-2564) Create new log4j config for unit tests so that logged messages contain threads

["Peter Bacsko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393626#comment-15393626 ] 

Peter Bacsko edited comment on OOZIE-2564 at 7/26/16 12:05 PM:
---------------------------------------------------------------

[~rkanter] thanks for the comments, I'll make the changes.

I have another idea. There are still a couple of tests that fail and the reason for the failure is completely obscure. I believe the current level of logging is simply not fine grained enough. Not to mention that I'm unable to reproduce many of the test failures, which is very frustrating.

I recommend using the following:

{code}
log4j.appender.test=org.apache.log4j.ConsoleAppender
log4j.appender.test.Target=System.out
log4j.appender.test.layout=org.apache.log4j.PatternLayout
log4j.appender.test.layout.ConversionPattern=%d{ABSOLUTE} [%t] %5p %c{1}:%L - %m%n

log4j.rootLogger=DEBUG, test
{code}

That is, we log everything on DEBUG level. Also, it's can be very useful to see what it's inserted to the database, so we should add the following line to {{persistence.xml}} 

{code}
<property name="openjpa.ConnectionFactoryProperties" value="PrintParameters=true" />
{code}


was (Author: pbacsko):
[~rkanter] thanks for the comments, I'll make the changes.

I have another idea. There are still a couple of tests that fail and the reason for the failure is completely obscure. I believe the current level of logging is simply not fine grained enough.

I recommend using the following:

{code}
log4j.appender.test=org.apache.log4j.ConsoleAppender
log4j.appender.test.Target=System.out
log4j.appender.test.layout=org.apache.log4j.PatternLayout
log4j.appender.test.layout.ConversionPattern=%d{ABSOLUTE} [%t] %5p %c{1}:%L - %m%n

log4j.rootLogger=DEBUG, test
{code}

That is, we log everything on DEBUG level. Also, it's can be very useful to see what it's inserted to the database, so we should add the following line to {{persistence.xml}} 

{code}
<property name="openjpa.ConnectionFactoryProperties" value="PrintParameters=true" />
{code}

> Create new log4j config for unit tests so that logged messages contain threads
> ------------------------------------------------------------------------------
>
>                 Key: OOZIE-2564
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2564
>             Project: Oozie
>          Issue Type: Bug
>          Components: core
>            Reporter: Peter Bacsko
>            Assignee: Peter Bacsko
>            Priority: Minor
>         Attachments: OOZIE-2564-001.patch, OOZIE-2564-002.patch
>
>
> During the discussion of OOZIE-2550, we concluded that including the threads in logged messages is helpful when we run unit tests.
> Note that the log4j config under src/main/resources is not modified.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)