You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by yvsubhash <gi...@git.apache.org> on 2015/10/10 21:47:26 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8944 Template download possibl...
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/921
CLOUDSTACK-8944 Template download possible from new nfs secondary storage before download is 100 % complete
Steps to test This
1. Add a new NFS storage
2. Start dowloading any public template before it is full dowloaded to new nfs storage
3. The link should always be from any of the older storages where it is fully downloaded
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-8944
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/921.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #921
----
commit 7055a34db133610f947d57542316505777938691
Author: subhash yedugundla <ve...@citrix.com>
Date: 2015-10-10T19:14:57Z
CLODUSTACK-8944 Template download possible from new nfs secondary storage before download is 100 % complete
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #921: CLOUDSTACK-8944 Template download possible from new n...
Posted by jayakarteek <gi...@git.apache.org>.
Github user jayakarteek commented on the issue:
https://github.com/apache/cloudstack/pull/921
unable to reproduce in ACS environment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8944 Template download possibl...
Posted by sateesh-chodapuneedi <gi...@git.apache.org>.
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/921#discussion_r41705286
--- Diff: server/src/com/cloud/template/TemplateManagerImpl.java ---
@@ -509,7 +509,7 @@ private String extract(Account caller, Long templateId, String url, Long zoneId,
for (DataStore store : ssStores) {
tmpltStoreRef = _tmplStoreDao.findByStoreTemplate(store.getId(), templateId);
if (tmpltStoreRef != null) {
- if (tmpltStoreRef.getDownloadState() == com.cloud.storage.VMTemplateStorageResourceAssoc.Status.DOWNLOADED) {
+ if (tmpltStoreRef.getDownloadState() == com.cloud.storage.VMTemplateStorageResourceAssoc.Status.DOWNLOADED && tmpltStoreRef.getDownloadPercent() == 100) {
--- End diff --
@yvsubhash thanks for the patch.
Can we address this (add this check) while setting the download state to DOWNLOADED? That way unless download progress is 100%, the template would not move to DOWNLOADED state.
Also good add a unit here, checking if template download progress is 100 if template state is DOWNLOADED.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8944 Template download possibl...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/921#issuecomment-150836992
@yvsubhash can you please respond to the comments and also rebase with current master please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8944 Template download possible from new...
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/921
### ACS CI BVT Run
**Sumarry:**
Build Number 96
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8944 Template download possibl...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/921#issuecomment-216195606
@yvsubhash please rebase against latest master and push -f, update on status of your PR
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #921: CLOUDSTACK-8944 Template download possible fro...
Posted by yvsubhash <gi...@git.apache.org>.
Github user yvsubhash closed the pull request at:
https://github.com/apache/cloudstack/pull/921
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #921: CLOUDSTACK-8944 Template download possible from new n...
Posted by yvsubhash <gi...@git.apache.org>.
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/921
Closing this PR, as this is no longer needed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---