[GitHub] [superset] suddjian commented on pull request #17123: fix(explore): remove unnecessary parameters from the explore url

[GitBox <gi...@apache.org>]

suddjian commented on pull request #17123:
URL: https://github.com/apache/superset/pull/17123#issuecomment-944813445


   > if we know these parameters are from dashboard, why not `_.omit` them from dashboard?
   
   It's a small difference, but it seems cleaner to me to have the url builder function take a full formData object and decide on its own what should go in the url.
   
   It would be nice if we had more of a schema for what is allowed/supposed to go in a formData, though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org