You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "moremind (via GitHub)" <gi...@apache.org> on 2023/09/08 03:02:09 UTC
[GitHub] [shenyu] moremind opened a new pull request, #5126: [type:fix] Fix websocket plugin
moremind opened a new pull request, #5126:
URL: https://github.com/apache/shenyu/pull/5126
<!-- Describe your PR here; eg. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #5126: [type:fix] Fix websocket plugin
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5126:
URL: https://github.com/apache/shenyu/pull/5126#issuecomment-1711020403
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5126?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5126](https://app.codecov.io/gh/apache/shenyu/pull/5126?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e4ae312) into [master](https://app.codecov.io/gh/apache/shenyu/commit/824ebacf0e833aa5c3ec06cf47a7b82c5f8e53f3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (824ebac) will **decrease** coverage by `0.76%`.
> The diff coverage is `33.33%`.
```diff
@@ Coverage Diff @@
## master #5126 +/- ##
============================================
- Coverage 61.72% 60.97% -0.76%
+ Complexity 8498 8420 -78
============================================
Files 1232 1232
Lines 36990 36990
Branches 3512 3508 -4
============================================
- Hits 22833 22554 -279
- Misses 12196 12534 +338
+ Partials 1961 1902 -59
```
| [Files Changed](https://app.codecov.io/gh/apache/shenyu/pull/5126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...in/response/strategy/NettyClientMessageWriter.java](https://app.codecov.io/gh/apache/shenyu/pull/5126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJlc3BvbnNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3Jlc3BvbnNlL3N0cmF0ZWd5L05ldHR5Q2xpZW50TWVzc2FnZVdyaXRlci5qYXZh) | `71.42% <0.00%> (-3.58%)` | :arrow_down: |
| [...ugin/response/strategy/WebClientMessageWriter.java](https://app.codecov.io/gh/apache/shenyu/pull/5126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJlc3BvbnNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3Jlc3BvbnNlL3N0cmF0ZWd5L1dlYkNsaWVudE1lc3NhZ2VXcml0ZXIuamF2YQ==) | `73.01% <0.00%> (ø)` | |
| [...pache/shenyu/plugin/websocket/WebSocketPlugin.java](https://app.codecov.io/gh/apache/shenyu/pull/5126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXByb3h5L3NoZW55dS1wbHVnaW4td2Vic29ja2V0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3dlYnNvY2tldC9XZWJTb2NrZXRQbHVnaW4uamF2YQ==) | `54.66% <100.00%> (+0.61%)` | :arrow_up: |
... and [25 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/5126/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yu199195 merged pull request #5126: [type:fix] Fix websocket plugin
Posted by "yu199195 (via GitHub)" <gi...@apache.org>.
yu199195 merged PR #5126:
URL: https://github.com/apache/shenyu/pull/5126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org