You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/10 14:09:04 UTC

[GitHub] [incubator-nuttx-apps] yamt commented on a change in pull request #472: Fix random printf format warnings and type mismatches

yamt commented on a change in pull request #472:
URL: https://github.com/apache/incubator-nuttx-apps/pull/472#discussion_r520588806



##########
File path: include/graphics/nxwidgets/itextbox.hxx
##########
@@ -208,7 +208,7 @@ namespace NXWidgets
      * @return position The cursor position.
      */
 
-    virtual const int getCursorPosition(void) const = 0;
+    virtual const int32_t getCursorPosition(void) const = 0;

Review comment:
       i dunno. i'm not familiar with this piece of code.
   is there any reason to prefer int over int32_t here?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org