Re: [PR] [SPARK-53143][SQL] Fix self join in DataFrame API - Join is not the only expected output from analyzer [spark]

["davidm-db (via GitHub)" <gi...@apache.org>]

davidm-db commented on code in PR #51873:
URL: https://github.com/apache/spark/pull/51873#discussion_r2303468227


##########
sql/core/src/main/scala/org/apache/spark/sql/classic/Dataset.scala:
##########
@@ -660,28 +660,40 @@ class Dataset[T] private[sql](
 
     // Trigger analysis so in the case of self-join, the analyzer will clone the plan.
     // After the cloning, left and right side will have distinct expression ids.
-    val plan = withPlan(
-      Join(logicalPlan, right.logicalPlan,
-        JoinType(joinType), joinExprs.map(_.expr), JoinHint.NONE))
-      .queryExecution.analyzed.asInstanceOf[Join]
+    val planToAnalyze = Join(

Review Comment:
   `dev/scalafmt` is not complaining and I don't like the way IntelliJ changes the code. Everything seems to be per scala/Spark guidelines, so I'll keep it as-is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org