You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Maxim Solodovnik <so...@gmail.com> on 2020/04/27 15:28:19 UTC
wicket-bootstrap date-time-picker
Hello Martin,
I found some weird behavior of bootstrap-date-time-picker
It seems `date` option
https://tempusdominus.github.io/bootstrap-4/Options/#date
need to be provided if `maxDate`
https://tempusdominus.github.io/bootstrap-4/Options/#minmaxdate
was specified
(otherwise current date will be displayed regardless of Model value...)
How do you think would it be OK to add additional `IKey` here
https://github.com/l0rdn1kk0n/wicket-bootstrap/blob/wicket-9.x-bootstrap-4.x/bootstrap-extensions/src/main/java/de/agilecoders/wicket/extensions/markup/html/bootstrap/form/datetime/DatetimePickerConfig.java#L67
(with setters)
Or any other changes are required?
--
Best regards,
Maxim
Re: wicket-bootstrap date-time-picker
Posted by Maxim Solodovnik <so...@gmail.com>.
Done
https://github.com/l0rdn1kk0n/wicket-bootstrap/pull/860
Thanks :)
On Tue, 28 Apr 2020 at 12:00, Martin Grigorov <mg...@apache.org> wrote:
>
> Hi Maxim,
>
> On Mon, Apr 27, 2020 at 6:28 PM Maxim Solodovnik <so...@gmail.com>
> wrote:
>
> > Hello Martin,
> >
> > I found some weird behavior of bootstrap-date-time-picker
> > It seems `date` option
> > https://tempusdominus.github.io/bootstrap-4/Options/#date
> > need to be provided if `maxDate`
> > https://tempusdominus.github.io/bootstrap-4/Options/#minmaxdate
> > was specified
> >
> > (otherwise current date will be displayed regardless of Model value...)
> >
> > How do you think would it be OK to add additional `IKey` here
> >
> > https://github.com/l0rdn1kk0n/wicket-bootstrap/blob/wicket-9.x-bootstrap-4.x/bootstrap-extensions/src/main/java/de/agilecoders/wicket/extensions/markup/html/bootstrap/form/datetime/DatetimePickerConfig.java#L67
> > (with setters)
> >
> > Or any other changes are required?
> >
>
> Please add any missing options you need!
> Thank you!
>
> Martin
>
>
> >
> >
> > --
> > Best regards,
> > Maxim
> >
--
Best regards,
Maxim
Re: wicket-bootstrap date-time-picker
Posted by Martin Grigorov <mg...@apache.org>.
Hi Maxim,
On Mon, Apr 27, 2020 at 6:28 PM Maxim Solodovnik <so...@gmail.com>
wrote:
> Hello Martin,
>
> I found some weird behavior of bootstrap-date-time-picker
> It seems `date` option
> https://tempusdominus.github.io/bootstrap-4/Options/#date
> need to be provided if `maxDate`
> https://tempusdominus.github.io/bootstrap-4/Options/#minmaxdate
> was specified
>
> (otherwise current date will be displayed regardless of Model value...)
>
> How do you think would it be OK to add additional `IKey` here
>
> https://github.com/l0rdn1kk0n/wicket-bootstrap/blob/wicket-9.x-bootstrap-4.x/bootstrap-extensions/src/main/java/de/agilecoders/wicket/extensions/markup/html/bootstrap/form/datetime/DatetimePickerConfig.java#L67
> (with setters)
>
> Or any other changes are required?
>
Please add any missing options you need!
Thank you!
Martin
>
>
> --
> Best regards,
> Maxim
>