You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/07/16 12:14:53 UTC

[GitHub] [zookeeper] ctubbsii commented on pull request #1401: ZOOKEEPER-3888: Add source and target version for compile plugin

ctubbsii commented on pull request #1401:
URL: https://github.com/apache/zookeeper/pull/1401#issuecomment-659371621


   > > This is unnecessary. This is already handled with the properties `maven.compiler.source` and `maven.compiler.target`. Setting them here is redundant, and makes it hard to change later (because you'd have to change in multiple places).
   > > I advise closing this PR and NOT applying the proposed changes.
   > 
   > Can you compile from the master branch without this change ?
   
   Yes. It compiles perfectly.
   I skipped the tests, because my system is too busy to run those right now, so the command I used was: `mvn clean verify -DskipTests -DskipITs`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org