[GitHub] [bookkeeper] eolivelli commented on a diff in pull request #3314: [WIP] Remove gradle from workflow

[GitBox <gi...@apache.org>]

eolivelli commented on code in PR #3314:
URL: https://github.com/apache/bookkeeper/pull/3314#discussion_r889885345


##########
.github/workflows/backward-compat-tests.yml:
##########
@@ -49,10 +49,17 @@ jobs:
         with:
           java-version: 1.8
       - name: Build
-        run: ./gradlew stream:server:build -x test ${GRADLE_ARGS}
+        run: mvn -B -nsu -am -pl :stream-storage-server test

Review Comment:
   this is not the same thing.
   in Gradle "-x test" means to skip tests and not to run tests



##########
pom.xml:
##########
@@ -148,7 +148,7 @@
     <!-- required by zookeeper test utilities imported from ZooKeeper -->
     <junit5.version>5.8.2</junit5.version>
     <libthrift.version>0.14.2</libthrift.version>
-    <lombok.version>1.18.22</lombok.version>
+    <lombok.version>1.18.24</lombok.version>

Review Comment:
   please upgrade dependencies in a separate PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org