You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/01/05 04:47:03 UTC

[GitHub] [hudi] alexeykudinkin commented on a change in pull request #4234: [HUDI-2950] Addressing performance traps in Bulk Insert/Layout Optimization

alexeykudinkin commented on a change in pull request #4234:
URL: https://github.com/apache/hudi/pull/4234#discussion_r778543602



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java
##########
@@ -90,7 +90,7 @@ public static long getObjectSize(Object obj) throws UnsupportedOperationExceptio
   private final Map<Class<?>, ClassSizeInfo> classSizeInfos = new IdentityHashMap<>();
 
   private final Set<Object> alreadyVisited = Collections.newSetFromMap(new IdentityHashMap<>());
-  private final Deque<Object> pending = new ArrayDeque<>(16 * 1024);
+  private final Deque<Object> pending = new ArrayDeque<>(64);

Review comment:
       Reducing upfront allocation w/ every Calculator object from 128kb to 512b




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org