You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/07/11 00:17:29 UTC
Re: Review Request 60336: Windows: Made environment abstractions use
Unicode.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60336/#review180124
-----------------------------------------------------------
Ship it!
3rdparty/stout/include/stout/os/windows/getenv.hpp
Line 41 (original), 43 (patched)
<https://reviews.apache.org/r/60336/#comment255145>
Hum. The rest of this chain uses `.reserve` when hitting this pattern.
- Joseph Wu
On June 21, 2017, 3:16 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60336/
> -----------------------------------------------------------
>
> (Updated June 21, 2017, 3:16 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park.
>
>
> Bugs: MESOS-6817
> https://issues.apache.org/jira/browse/MESOS-6817
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Made environment abstractions use Unicode.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/environment.hpp 96f0eb4f56a73f4058eeaf68502e441bd00147a8
> 3rdparty/stout/include/stout/os/windows/getenv.hpp 2200f8527da0c8d5a5ffee287eb86e4d0cb58b8b
> 3rdparty/stout/include/stout/windows/os.hpp f1722d5e18af97d89c6ca7aaf002fd58cb0d21ae
>
>
> Diff: https://reviews.apache.org/r/60336/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>