You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/09/07 14:41:08 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #7492: Minor: Add ScalarValue::data_type() for consistency
alamb opened a new pull request, #7492:
URL: https://github.com/apache/arrow-datafusion/pull/7492
## Which issue does this PR close?
N/A
## Rationale for this change
The fact that most of the DataFusion codebase uses `fn data_type()` to retrieve the datatype but `ScalarValue` uses `get_datatype` is frustrating to me. It is a very small rough edge, but one that is easy to fix
## What changes are included in this PR?
1. Add `ScalarValue::data_type()`
2. Add docs to `ScalarValue::get_datatype`
Note I did not actually `#deprecate` get_datatype as I thought that would be too large a change. I can do so if people would like however.
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
I changed a few locations to call `ScalarValue::data_type`
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
4. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] viirya commented on a diff in pull request #7492: Minor: Add `ScalarValue::data_type()` for consistency with other APIs
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #7492:
URL: https://github.com/apache/arrow-datafusion/pull/7492#discussion_r1318785274
##########
datafusion/common/src/scalar.rs:
##########
@@ -1149,6 +1149,13 @@ impl ScalarValue {
}
}
+ /// Getter for the `DataType` of the value.
+ ///
+ /// Suggest using [`Self::data_type`] as a more standard API
+ pub fn get_datatype(&self) -> DataType {
+ self.data_type()
+ }
Review Comment:
Do we want to deprecate this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #7492: Minor: Add `ScalarValue::data_type()` for consistency with other APIs
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #7492:
URL: https://github.com/apache/arrow-datafusion/pull/7492#discussion_r1318899619
##########
datafusion/common/src/scalar.rs:
##########
@@ -1149,6 +1149,13 @@ impl ScalarValue {
}
}
+ /// Getter for the `DataType` of the value.
+ ///
+ /// Suggest using [`Self::data_type`] as a more standard API
+ pub fn get_datatype(&self) -> DataType {
+ self.data_type()
+ }
Review Comment:
We could/should -- I was basically being lazy.
I'll try and find time to bash out a follow on PR to deprecate it and update the uses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan merged pull request #7492: Minor: Add `ScalarValue::data_type()` for consistency with other APIs
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan merged PR #7492:
URL: https://github.com/apache/arrow-datafusion/pull/7492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #7492: Minor: Add `ScalarValue::data_type()` for consistency with other APIs
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #7492:
URL: https://github.com/apache/arrow-datafusion/pull/7492#discussion_r1319677060
##########
datafusion/common/src/scalar.rs:
##########
@@ -1149,6 +1149,13 @@ impl ScalarValue {
}
}
+ /// Getter for the `DataType` of the value.
+ ///
+ /// Suggest using [`Self::data_type`] as a more standard API
+ pub fn get_datatype(&self) -> DataType {
+ self.data_type()
+ }
Review Comment:
Filed https://github.com/apache/arrow-datafusion/issues/7506 to track
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org