You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by Andun Sameera <an...@gmail.com> on 2013/04/02 10:35:44 UTC
Re: Error message is shown when user save the Profile settings - OPENMEETINGS-507
I have deeply looked in to this issue. When the "Save" button is
clicked, following code in the
/singlewebapp/WebContent/src/modules/conference/popups/rpcerrorDialog.lzx
is executed. That is responsible to show the pop up message.
<class name="contentSaveWindow" extends="baseErrorDialog">
<attribute name="saveObj" value="null" />
<attribute name="refObj" value="null" />
<attribute name="processNextIndex" value="0" type="number" />
<attribute name="errorid" value="0" type="number" />
<handler name="oninit">
lz.ModeManager.makeModal(this);
if ($debug) Debug.write("contentsavewindow: ",errorid);
this.startSave();
</handler>
<handler name="onclose">
lz.ModeManager.release(this);
</handler>
<method name="startSave">
<![CDATA[
for (var i=0;i<this.saveObj.length;i++){
this.saveObj[i].prepareCall();
}
this.processNext();
]]>
</method>
<method name="errorByCode" args="eCode">
this.errorid = eCode;
this.getErrorByCode.doCall();
</method>
<method name="processNext">
<![CDATA[
//Debug.write("processNext: ",this.saveObj.length,this.processNextIndex);
if (this.saveObj.length>this.processNextIndex){
this.saveObj[this.processNextIndex].returnObj=this;
this.saveObj[this.processNextIndex].doCall();
this.processNextIndex++;
} else {
//Debug.write("update process complete");
this.refObj.onsavecompleted.sendEvent();
this.close();
}
]]>
</method>
<method name="doCallBack">
this.close();
</method>
<simpleLabelButton name="_btn" labelid="333" width="100" x="$once{
parent.width-104 }"
y="$once{ parent.height-24 }" onclick="parent.doCallBack();" />
</class>
I think the pop up of this dialog is not caused by a error. But the
false content shown in the dialog is causing the problem. Basically
this pop up message is showed to indicated the the Save process is
completed. So the problem I found is,
-Message goes invisible just after it shows
-The title and content of the message is a error message while in this
particular context it is showed to indicated the completion of the
save process.
The first problem can be easily corrected by removing the
this.close(); call in the processNext method. But what should be the
way to correct the second problem ? Can we create a save completion
dialog by extending baseErrorDialog ?
On Fri, Mar 29, 2013 at 6:31 PM, Andun Sameera <an...@gmail.com> wrote:
> Hi,
>
> So I will look in to this.
>
> Thanks
> AndunSLG
>
> On Fri, Mar 29, 2013 at 5:17 PM, Vasya <va...@unipro.ru> wrote:
>> Hi Andun,
>>
>> This bug is not fixed in the latest trunk.
>>
>> Thanks,
>> Vasiliy
>>
>>
>> On 29.03.2013 18:30, Andun Sameera wrote:
>>>
>>> Hi Devs,
>>>
>>> When I am going through the Jira Issues, I cam across this
>>> https://issues.apache.org/jira/browse/OPENMEETINGS-507. So to check
>>> this I have locally setup a OM server with
>>> apache-openmeetings-incubating-2.0.0.r1361497-14-07-2012_1108(Since I
>>> am currently unable to build the trunk, already sent a mail to dev). I
>>> think I can reproduce this,
>>>
>>> Steps,
>>>
>>> -Login to the OM
>>> -Go to profile tab
>>> -Go to Edit Setting Tab
>>> -Do some changes and click save button
>>> -A message shows and goes invisible suddenly. It has the title Error.
>>>
>>> I am trying to look in to this in the code. I think this is not fixed
>>> in the latest trunk.
>>>
>>> Thanks
>>> AndunSLG
>>
>>
--
Regards
Andun S.L. Gunawardana
Undergraduate
Department of Computer Science And Engineering
University of Moratuwa
Sri Lanka
Blog - http://www.insightforfuture.blogspot.com/
LinkedIn - http://www.linkedin.com/pub/andun-s-l-gunawardana/34/646/703
Twitter -http://twitter.com/AndunSLG
Re: Error message is shown when user save the Profile settings - OPENMEETINGS-507
Posted by Andun Sameera <an...@gmail.com>.
Hi,
Also I have noticed that the Save Completion dialog which is given by
the above coed is shown when
/singlewebapp/WebContent/src/base/contentviews/baseContentSaveView.lzx's
Save button is clicked. So each and every where baseContentSaveView is
used, this false message will come.
So what is the best way to correct this? I think creating a new dialog
will be good.
On Tue, Apr 2, 2013 at 2:05 PM, Andun Sameera <an...@gmail.com> wrote:
> I have deeply looked in to this issue. When the "Save" button is
> clicked, following code in the
> /singlewebapp/WebContent/src/modules/conference/popups/rpcerrorDialog.lzx
> is executed. That is responsible to show the pop up message.
>
> <class name="contentSaveWindow" extends="baseErrorDialog">
>
> <attribute name="saveObj" value="null" />
> <attribute name="refObj" value="null" />
> <attribute name="processNextIndex" value="0" type="number" />
> <attribute name="errorid" value="0" type="number" />
>
> <handler name="oninit">
> lz.ModeManager.makeModal(this);
> if ($debug) Debug.write("contentsavewindow: ",errorid);
> this.startSave();
> </handler>
>
> <handler name="onclose">
> lz.ModeManager.release(this);
> </handler>
>
> <method name="startSave">
> <![CDATA[
> for (var i=0;i<this.saveObj.length;i++){
> this.saveObj[i].prepareCall();
> }
> this.processNext();
> ]]>
> </method>
>
> <method name="errorByCode" args="eCode">
> this.errorid = eCode;
> this.getErrorByCode.doCall();
> </method>
>
> <method name="processNext">
> <![CDATA[
> //Debug.write("processNext: ",this.saveObj.length,this.processNextIndex);
> if (this.saveObj.length>this.processNextIndex){
> this.saveObj[this.processNextIndex].returnObj=this;
> this.saveObj[this.processNextIndex].doCall();
> this.processNextIndex++;
> } else {
> //Debug.write("update process complete");
> this.refObj.onsavecompleted.sendEvent();
> this.close();
> }
> ]]>
> </method>
>
> <method name="doCallBack">
> this.close();
> </method>
>
> <simpleLabelButton name="_btn" labelid="333" width="100" x="$once{
> parent.width-104 }"
> y="$once{ parent.height-24 }" onclick="parent.doCallBack();" />
>
> </class>
>
> I think the pop up of this dialog is not caused by a error. But the
> false content shown in the dialog is causing the problem. Basically
> this pop up message is showed to indicated the the Save process is
> completed. So the problem I found is,
>
> -Message goes invisible just after it shows
> -The title and content of the message is a error message while in this
> particular context it is showed to indicated the completion of the
> save process.
>
> The first problem can be easily corrected by removing the
> this.close(); call in the processNext method. But what should be the
> way to correct the second problem ? Can we create a save completion
> dialog by extending baseErrorDialog ?
>
> On Fri, Mar 29, 2013 at 6:31 PM, Andun Sameera <an...@gmail.com> wrote:
>> Hi,
>>
>> So I will look in to this.
>>
>> Thanks
>> AndunSLG
>>
>> On Fri, Mar 29, 2013 at 5:17 PM, Vasya <va...@unipro.ru> wrote:
>>> Hi Andun,
>>>
>>> This bug is not fixed in the latest trunk.
>>>
>>> Thanks,
>>> Vasiliy
>>>
>>>
>>> On 29.03.2013 18:30, Andun Sameera wrote:
>>>>
>>>> Hi Devs,
>>>>
>>>> When I am going through the Jira Issues, I cam across this
>>>> https://issues.apache.org/jira/browse/OPENMEETINGS-507. So to check
>>>> this I have locally setup a OM server with
>>>> apache-openmeetings-incubating-2.0.0.r1361497-14-07-2012_1108(Since I
>>>> am currently unable to build the trunk, already sent a mail to dev). I
>>>> think I can reproduce this,
>>>>
>>>> Steps,
>>>>
>>>> -Login to the OM
>>>> -Go to profile tab
>>>> -Go to Edit Setting Tab
>>>> -Do some changes and click save button
>>>> -A message shows and goes invisible suddenly. It has the title Error.
>>>>
>>>> I am trying to look in to this in the code. I think this is not fixed
>>>> in the latest trunk.
>>>>
>>>> Thanks
>>>> AndunSLG
>>>
>>>
>
>
>
> --
> Regards
> Andun S.L. Gunawardana
> Undergraduate
> Department of Computer Science And Engineering
> University of Moratuwa
> Sri Lanka
>
> Blog - http://www.insightforfuture.blogspot.com/
> LinkedIn - http://www.linkedin.com/pub/andun-s-l-gunawardana/34/646/703
> Twitter -http://twitter.com/AndunSLG
--
Regards
Andun S.L. Gunawardana
Undergraduate
Department of Computer Science And Engineering
University of Moratuwa
Sri Lanka
Blog - http://www.insightforfuture.blogspot.com/
LinkedIn - http://www.linkedin.com/pub/andun-s-l-gunawardana/34/646/703
Twitter -http://twitter.com/AndunSLG