[jira] [Commented] (ZOOKEEPER-2111) Not isAlive states should be synchronized in ClientCnxn

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294120#comment-14294120 ] 

Hadoop QA commented on ZOOKEEPER-2111:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12694824/ZOOKEEPER-2111.patch
  against trunk revision 1655082.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2493//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2493//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2493//console

This message is automatically generated.

> Not isAlive states should be synchronized in ClientCnxn
> -------------------------------------------------------
>
>                 Key: ZOOKEEPER-2111
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2111
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>            Reporter: Hongchao Deng
>            Assignee: Hongchao Deng
>         Attachments: ZOOKEEPER-2111.patch
>
>
> In ClientCnxn.queuePacket, it checks variables of state and closing and then make decisions. There is toctou race in queuePacket():
> {code}
>         if (!state.isAlive() || closing) {
>             conLossPacket(packet);
>         } else {
>             ...
>         }
> {code}
> A possible race:
> in SendThread.run():
> {code}
>   while (state.isAlive()) {
>     ...
>   }
>   cleanup();
> {code}
> When it checks in queuePacket(), state is still alive. Then state isn't alive, SendThread.run() cleans up outgoingQueue. Then queuePacket adds packet to outgoingQueue. The packet should be waken up with exception. But it won't at this case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)