[GitHub] [incubator-apisix] membphis commented on a change in pull request #976: Added password support for plugin limit-count-redis

[GitBox <gi...@apache.org>]

membphis commented on a change in pull request #976: Added password support for plugin limit-count-redis
URL: https://github.com/apache/incubator-apisix/pull/976#discussion_r373755626
 
 

 ##########
 File path: t/plugin/limit-count-redis.t
 ##########
 @@ -82,6 +82,10 @@ GET /t
     location /t {
         content_by_lua_block {
             local t = require("lib.test_admin").test
+            -- SET redis instance password
+            local tmp_auth = "foobared"
+            local val = redis.pcall('CONFIG', 'SET', 'requirepass', tmp_auth)
 
 Review comment:
   After running the test case, we need to restore the Redis state. Other plugins maybe need to use the Redis too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services