You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@weex.apache.org by GitBox <gi...@apache.org> on 2018/09/12 04:30:47 UTC

[GitHub] YorkShen commented on a change in pull request #1511: [WEEX-611][Android] Fix java.lang.ArrayIndexOutOfBoundsException

YorkShen commented on a change in pull request #1511: [WEEX-611][Android] Fix java.lang.ArrayIndexOutOfBoundsException
URL: https://github.com/apache/incubator-weex/pull/1511#discussion_r216893838
 
 

 ##########
 File path: android/sdk/src/main/java/com/taobao/weex/utils/batch/BatchOperationHelper.java
 ##########
 @@ -31,7 +32,7 @@
 
 
   private BactchExecutor mExecutor;
-  private ArrayList<Runnable> sRegisterTasks = new ArrayList<>();
+  private CopyOnWriteArrayList<Runnable> sRegisterTasks = new CopyOnWriteArrayList<>();
 
 Review comment:
   `CopyOnWriteArrayList` is bad for performance in high frequency invoke situation. Be careful

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services