You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/16 11:02:50 UTC

[GitHub] [spark] JkSelf commented on a change in pull request #27563: [SPARK-30812][SQL][CORE] Revise boolean config name to comply with new config naming policy

JkSelf commented on a change in pull request #27563: [SPARK-30812][SQL][CORE] Revise boolean config name to comply with new config naming policy
URL: https://github.com/apache/spark/pull/27563#discussion_r379894232
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -425,7 +425,7 @@ object SQLConf {
     .createWithDefault(true)
 
   val ADAPTIVE_EXECUTION_SKEWED_JOIN_ENABLED =
-    buildConf("spark.sql.adaptive.optimizeSkewedJoin.enabled")
+    buildConf("spark.sql.adaptive.optimizeSkewedJoin")
 
 Review comment:
   +1 for `spark.sql.adaptive.skewedJoinOptimization.enabled` to apply the naming guidelines.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org