You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/06/30 12:05:10 UTC

[jira] [Commented] (PROTON-1249) proton-j: unsafe type initialisations

    [ https://issues.apache.org/jira/browse/PROTON-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356975#comment-15356975 ] 

ASF GitHub Bot commented on PROTON-1249:
----------------------------------------

GitHub user dnwe opened a pull request:

    https://github.com/apache/qpid-proton/pull/76

    PROTON-1249: Safeguard type initialisations.

    In #readValue() for ArrayType, BinaryType, ListType and MapType
    decoding, if the 'count' specified is very large then it is likely to
    trigger an OutOfMemoryException. As these can come from an external data
    source, during the SASL init for example, there is a potential for a
    denial of service. The fix is to throw an IllegalArgumentException if
    the count value is larger than the amount of data available in the
    received bytes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dnwe/qpid-proton PROTON-1249

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-proton/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #76
    
----
commit 0c92828864118517f8d8a23a2801da82852cf36c
Author: Dominic Evans <do...@uk.ibm.com>
Date:   2016-03-18T11:20:23Z

    PROTON-1249: Safeguard type initialisations.
    
    In #readValue() for ArrayType, BinaryType, ListType and MapType
    decoding, if the 'count' specified is very large then it is likely to
    trigger an OutOfMemoryException. As these can come from an external data
    source, during the SASL init for example, there is a potential for a
    denial of service. The fix is to throw an IllegalArgumentException if
    the count value is larger than the amount of data available in the
    received bytes.

----


> proton-j: unsafe type initialisations
> -------------------------------------
>
>                 Key: PROTON-1249
>                 URL: https://issues.apache.org/jira/browse/PROTON-1249
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-j
>    Affects Versions: 0.12.2
>            Reporter: Dominic Evans
>            Assignee: Dominic Evans
>              Labels: proton-j, security
>
> In #readValue() for ArrayType, BinaryType, ListType and MapType
> decoding, if the 'count' specified is very large then it is likely to
> trigger an OutOfMemoryException. As these can come from an external data
> source, during the SASL init for example, there is a potential for a
> denial of service. The fix is to throw an IllegalArgumentException if
> the count value is larger than the amount of data available in the
> received bytes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org