You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2016/11/08 16:11:59 UTC
[GitHub] incubator-beam pull request #1313: [BEAM-937][BEAM-938] Update Watermarks ev...
GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/1313
[BEAM-937][BEAM-938] Update Watermarks even if a Reader is empty
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
This ensures that the pipeline will make progress even if a reader stops
producing elements.
Fixes the test bug introduced in #1300 and reverts the rollback of #1303
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam revert_empty_reader_wms
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1313.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1313
----
commit 907aae24f5b0f59420b6ba421380accdb9ac7cb7
Author: Thomas Groh <tg...@google.com>
Date: 2016-11-07T20:59:06Z
Update Watermarks even if a Reader is empty
This ensures that the pipeline will make progress even if a reader stops
producing elements.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #1313: [BEAM-937][BEAM-938] Update Watermarks ev...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/1313
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---