You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Swapan Shridhar <ss...@hortonworks.com> on 2017/01/17 00:24:39 UTC
Review Request 55593: AMBARI-19547. HSI tez am memory set to 0,
incorrect calcaultions for non llap queues
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55593/
-----------------------------------------------------------
Review request for Ambari, Sumit Mohanty and Swapan Shridhar.
Bugs: AMBARI-19547
https://issues.apache.org/jira/browse/AMBARI-19547
Repository: ambari
Description
-------
Path by Siddharth Seth.
Patch contains the following changes.
- Sets the am parameter to SET_ON_FIRST_INVOCATION so that it is computed.
- Modifies the way #nodes is calculated for non ambari controlled queues (BUG related to the computed size of the daemon being too large in this case)
- Adds an improvement to the queue capacity determination (queue name check)
- Re-adds most logging that was removed in AMBARI-19171Link
- Modifies the display-name and description of some config parameters.
Diffs
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py f2f0554
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml a1f6d22
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml 2fb1553
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml b331736
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py b08ce75
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml 1c6bc3f
Diff: https://reviews.apache.org/r/55593/diff/
Testing
-------
Yes
Thanks,
Swapan Shridhar
Re: Review Request 55593: AMBARI-19547. HSI tez am memory set to 0,
incorrect calcaultions for non llap queues
Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55593/#review161803
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
<https://reviews.apache.org/r/55593/#comment233111>
Required.
- Swapan Shridhar
On Jan. 17, 2017, 12:24 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55593/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2017, 12:24 a.m.)
>
>
> Review request for Ambari, Sumit Mohanty and Swapan Shridhar.
>
>
> Bugs: AMBARI-19547
> https://issues.apache.org/jira/browse/AMBARI-19547
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Path by Siddharth Seth.
>
> Patch contains the following changes.
> - Sets the am parameter to SET_ON_FIRST_INVOCATION so that it is computed.
> - Modifies the way #nodes is calculated for non ambari controlled queues (BUG related to the computed size of the daemon being too large in this case)
> - Adds an improvement to the queue capacity determination (queue name check)
> - Re-adds most logging that was removed in AMBARI-19171Link
> - Modifies the display-name and description of some config parameters.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py f2f0554
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml a1f6d22
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml 2fb1553
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml b331736
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py b08ce75
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml 1c6bc3f
>
> Diff: https://reviews.apache.org/r/55593/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 55593: AMBARI-19547. HSI tez am memory set to 0,
incorrect calcaultions for non llap queues
Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55593/#review161802
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 292)
<https://reviews.apache.org/r/55593/#comment233107>
Extra space.
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 796)
<https://reviews.apache.org/r/55593/#comment233108>
Extra 1 at the end.
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 802)
<https://reviews.apache.org/r/55593/#comment233109>
Extra 1 at the end.
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 897)
<https://reviews.apache.org/r/55593/#comment233110>
typo : down
- Swapan Shridhar
On Jan. 17, 2017, 12:24 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55593/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2017, 12:24 a.m.)
>
>
> Review request for Ambari, Sumit Mohanty and Swapan Shridhar.
>
>
> Bugs: AMBARI-19547
> https://issues.apache.org/jira/browse/AMBARI-19547
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Path by Siddharth Seth.
>
> Patch contains the following changes.
> - Sets the am parameter to SET_ON_FIRST_INVOCATION so that it is computed.
> - Modifies the way #nodes is calculated for non ambari controlled queues (BUG related to the computed size of the daemon being too large in this case)
> - Adds an improvement to the queue capacity determination (queue name check)
> - Re-adds most logging that was removed in AMBARI-19171Link
> - Modifies the display-name and description of some config parameters.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py f2f0554
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml a1f6d22
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml 2fb1553
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml b331736
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py b08ce75
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml 1c6bc3f
>
> Diff: https://reviews.apache.org/r/55593/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 55593: AMBARI-19547. HSI tez am memory set to 0,
incorrect calculations for non llap queues
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55593/#review161804
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Jan. 17, 2017, 12:41 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55593/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2017, 12:41 a.m.)
>
>
> Review request for Ambari, Sumit Mohanty and Swapan Shridhar.
>
>
> Bugs: AMBARI-19547
> https://issues.apache.org/jira/browse/AMBARI-19547
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Path by Siddharth Seth.
>
> Patch contains the following changes.
> - Sets the am parameter to SET_ON_FIRST_INVOCATION so that it is computed.
> - Modifies the way #nodes is calculated for non ambari controlled queues (BUG related to the computed size of the daemon being too large in this case)
> - Adds an improvement to the queue capacity determination (queue name check)
> - Re-adds most logging that was removed in AMBARI-19171Link
> - Modifies the display-name and description of some config parameters.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py f2f0554
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml a1f6d22
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml 2fb1553
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml b331736
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py b08ce75
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml 1c6bc3f
>
> Diff: https://reviews.apache.org/r/55593/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 55593: AMBARI-19547. HSI tez am memory set to 0,
incorrect calculations for non llap queues
Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55593/
-----------------------------------------------------------
(Updated Jan. 17, 2017, 12:41 a.m.)
Review request for Ambari, Sumit Mohanty and Swapan Shridhar.
Summary (updated)
-----------------
AMBARI-19547. HSI tez am memory set to 0, incorrect calculations for non llap queues
Bugs: AMBARI-19547
https://issues.apache.org/jira/browse/AMBARI-19547
Repository: ambari
Description
-------
Path by Siddharth Seth.
Patch contains the following changes.
- Sets the am parameter to SET_ON_FIRST_INVOCATION so that it is computed.
- Modifies the way #nodes is calculated for non ambari controlled queues (BUG related to the computed size of the daemon being too large in this case)
- Adds an improvement to the queue capacity determination (queue name check)
- Re-adds most logging that was removed in AMBARI-19171Link
- Modifies the display-name and description of some config parameters.
Diffs
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py f2f0554
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml a1f6d22
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml 2fb1553
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml b331736
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py b08ce75
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml 1c6bc3f
Diff: https://reviews.apache.org/r/55593/diff/
Testing
-------
Yes
Thanks,
Swapan Shridhar