You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/06 12:47:59 UTC

[GitHub] flinkbot edited a comment on issue #7653: [FLINK-11367][tests] Port TaskManagerProcessReapingTestBase to new codebase

flinkbot edited a comment on issue #7653: [FLINK-11367][tests] Port TaskManagerProcessReapingTestBase to new codebase
URL: https://github.com/apache/flink/pull/7653#issuecomment-460959254
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Review Progress
   
   * ❌ 1. The [description] looks good.
   * ✅ 2. There is [consensus] that the contribution should go into to Flink.
       - Approved by @zentol [PMC]
   * ❔ 3. Needs [attention] from.
   * ❌ 4. The [architecture] is sound.
   * ❌ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/reviewing-prs.html) for a full explanation of the review process.<details>
     <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve the 1st aspect (similarly, it also supports the `consensus`, `architecture` and `quality` keywords)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services