You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hawq.apache.org by li...@apache.org on 2016/02/17 03:17:19 UTC
[2/3] incubator-hawq git commit: HAWQ-407. Remove unnecessary comments
HAWQ-407. Remove unnecessary comments
Project: http://git-wip-us.apache.org/repos/asf/incubator-hawq/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-hawq/commit/cf59b7b6
Tree: http://git-wip-us.apache.org/repos/asf/incubator-hawq/tree/cf59b7b6
Diff: http://git-wip-us.apache.org/repos/asf/incubator-hawq/diff/cf59b7b6
Branch: refs/heads/master
Commit: cf59b7b66beef57eda08f39472a98c43d6b76f18
Parents: 9defbc1
Author: Lili Ma <lm...@pivotal.io>
Authored: Wed Feb 17 09:28:32 2016 +0800
Committer: Lili Ma <lm...@pivotal.io>
Committed: Wed Feb 17 09:28:32 2016 +0800
----------------------------------------------------------------------
src/backend/access/parquet/parquetam.c | 4 ----
src/backend/cdb/cdbparquetfooterserializer.c | 3 ---
2 files changed, 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/cf59b7b6/src/backend/access/parquet/parquetam.c
----------------------------------------------------------------------
diff --git a/src/backend/access/parquet/parquetam.c b/src/backend/access/parquet/parquetam.c
index 6438e32..3c2b7df 100644
--- a/src/backend/access/parquet/parquetam.c
+++ b/src/backend/access/parquet/parquetam.c
@@ -583,10 +583,6 @@ ParquetInsertDesc parquet_insert_init(Relation rel, ResultRelSegFileInfo *segfil
parquetInsertDesc->aoEntry = aoentry;
parquetInsertDesc->insertCount = 0;
-// parquetInsertDesc->parquetMetadata = (struct ParquetMetadata_4C *)
-// palloc0(sizeof(struct ParquetMetadata_4C));
- /*SHOULD CALL OPEN METADATA FILE HERE, AND GET parquetMetadata INFO*/
-
initStringInfo(&titleBuf);
appendStringInfo(&titleBuf, "Write of Parquet relation '%s'",
RelationGetRelationName(parquetInsertDesc->parquet_rel));
http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/cf59b7b6/src/backend/cdb/cdbparquetfooterserializer.c
----------------------------------------------------------------------
diff --git a/src/backend/cdb/cdbparquetfooterserializer.c b/src/backend/cdb/cdbparquetfooterserializer.c
index 247bbb1..802793f 100644
--- a/src/backend/cdb/cdbparquetfooterserializer.c
+++ b/src/backend/cdb/cdbparquetfooterserializer.c
@@ -167,9 +167,6 @@ void initDeserializeFooter(
initCompactProtocol(*footerProtocol, file, fileName, footerLength, PARQUET_FOOTER_BUFFERMODE_READ);
-// *parquetMetadata =
-// (struct ParquetMetadata_4C*) palloc0(sizeof(struct ParquetMetadata_4C));
-
readParquetFileMetadata(parquetMetadata, *footerProtocol);
}