You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ed Kohlwey (JIRA)" <ji...@apache.org> on 2010/12/07 23:11:02 UTC

[jira] Created: (HBASE-3317) Javadoc and Throws Declaration for Bytes.incrementBytes() is Wrong

Javadoc and Throws Declaration for Bytes.incrementBytes() is Wrong
------------------------------------------------------------------

                 Key: HBASE-3317
                 URL: https://issues.apache.org/jira/browse/HBASE-3317
             Project: HBase
          Issue Type: Bug
            Reporter: Ed Kohlwey


The throws declaration for Bytes.incrementBytes() states that an IOException is thrown by the method, and javadocs suggest that this is expected if the byte array's size is larger than SIZEOF_LONG.

The code actually uses an IllegalArgumentException, which is probably more appropriate anyways. This should be changed to simplify the code that uses this method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-3317) Javadoc and Throws Declaration for Bytes.incrementBytes() is Wrong

Posted by "Ed Kohlwey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ed Kohlwey updated HBASE-3317:
------------------------------

    Priority: Trivial  (was: Major)

> Javadoc and Throws Declaration for Bytes.incrementBytes() is Wrong
> ------------------------------------------------------------------
>
>                 Key: HBASE-3317
>                 URL: https://issues.apache.org/jira/browse/HBASE-3317
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ed Kohlwey
>            Priority: Trivial
>
> The throws declaration for Bytes.incrementBytes() states that an IOException is thrown by the method, and javadocs suggest that this is expected if the byte array's size is larger than SIZEOF_LONG.
> The code actually uses an IllegalArgumentException, which is probably more appropriate anyways. This should be changed to simplify the code that uses this method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-3317) Javadoc and Throws Declaration for Bytes.incrementBytes() is Wrong

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-3317.
--------------------------

       Resolution: Fixed
    Fix Version/s: 0.92.0
     Hadoop Flags: [Reviewed]

Committed to TRUNK.  Thank you for the patch Ed.

> Javadoc and Throws Declaration for Bytes.incrementBytes() is Wrong
> ------------------------------------------------------------------
>
>                 Key: HBASE-3317
>                 URL: https://issues.apache.org/jira/browse/HBASE-3317
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ed Kohlwey
>            Priority: Trivial
>             Fix For: 0.92.0
>
>         Attachments: HBASE-3317.patch
>
>
> The throws declaration for Bytes.incrementBytes() states that an IOException is thrown by the method, and javadocs suggest that this is expected if the byte array's size is larger than SIZEOF_LONG.
> The code actually uses an IllegalArgumentException, which is probably more appropriate anyways. This should be changed to simplify the code that uses this method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-3317) Javadoc and Throws Declaration for Bytes.incrementBytes() is Wrong

Posted by "Ed Kohlwey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ed Kohlwey updated HBASE-3317:
------------------------------

    Attachment: HBASE-3317.patch

> Javadoc and Throws Declaration for Bytes.incrementBytes() is Wrong
> ------------------------------------------------------------------
>
>                 Key: HBASE-3317
>                 URL: https://issues.apache.org/jira/browse/HBASE-3317
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ed Kohlwey
>            Priority: Trivial
>         Attachments: HBASE-3317.patch
>
>
> The throws declaration for Bytes.incrementBytes() states that an IOException is thrown by the method, and javadocs suggest that this is expected if the byte array's size is larger than SIZEOF_LONG.
> The code actually uses an IllegalArgumentException, which is probably more appropriate anyways. This should be changed to simplify the code that uses this method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HBASE-3317) Javadoc and Throws Declaration for Bytes.incrementBytes() is Wrong

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack reassigned HBASE-3317:
----------------------------

    Assignee: Ed Kohlwey

> Javadoc and Throws Declaration for Bytes.incrementBytes() is Wrong
> ------------------------------------------------------------------
>
>                 Key: HBASE-3317
>                 URL: https://issues.apache.org/jira/browse/HBASE-3317
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ed Kohlwey
>            Assignee: Ed Kohlwey
>            Priority: Trivial
>             Fix For: 0.92.0
>
>         Attachments: HBASE-3317.patch
>
>
> The throws declaration for Bytes.incrementBytes() states that an IOException is thrown by the method, and javadocs suggest that this is expected if the byte array's size is larger than SIZEOF_LONG.
> The code actually uses an IllegalArgumentException, which is probably more appropriate anyways. This should be changed to simplify the code that uses this method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.