[jira] [Commented] (AVRO-1545) python bindings for avro discard customized type information for primitive types

["Ryan Blue (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248789#comment-14248789 ] 

Ryan Blue commented on AVRO-1545:
---------------------------------

+1 (non-binding)

This looks fine to me. I think all of the places where PrimitiveSchema is instantiated are correct and the tests pass.

> python bindings for avro discard customized type information for primitive types
> --------------------------------------------------------------------------------
>
>                 Key: AVRO-1545
>                 URL: https://issues.apache.org/jira/browse/AVRO-1545
>             Project: Avro
>          Issue Type: Bug
>          Components: python
>    Affects Versions: 1.7.6
>            Reporter: Dustin Spicuzza
>            Assignee: Dustin Spicuzza
>             Fix For: 1.8.0
>
>         Attachments: types.diff
>
>
> Given the following avsc file:
> {
>   "type" : "record",
>   "name" : "BrokenRecord",
>   "namespace" : "whatever",
>   "fields" : [ {
>     "name" : "a_string",
>     "type" : {
>       "type" : "string",
>       "avro.java.string" : "String"
>     }
>   } ]
> }
> The python schema parser discards the avro.java.string marker, which breaks interoperability with java. In schema.py, it discards the other property information and compresses the type down to just a 'string'.
> Patch attached against the 1.7.6 release. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)