You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Jerome Lacoste (JIRA)" <ji...@codehaus.org> on 2005/06/09 11:19:09 UTC

[jira] Created: (MNG-463) [data loss] installation script inconditionally deletes M2_HOME contents

[data loss] installation script inconditionally deletes M2_HOME contents
------------------------------------------------------------------------

         Key: MNG-463
         URL: http://jira.codehaus.org/browse/MNG-463
     Project: Maven 2
        Type: Improvement
    Versions: 2.0-alpha-3    
    Reporter: Jerome Lacoste
    Priority: Critical


I've set up M2_HOME to a wrong directory by mistake, and the m2 installer deleted everything in it...
May I suggest to use the same strategy used by the cargo installer?

I.e. 

if (target directory empty || m2 marker file exists)
- copy the contents
- add a marker file specific to m2
else
  warn user

See CARGO-27 for the original CARGO issue.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-463) [data loss] installation script inconditionally deletes M2_HOME contents

Posted by "Jerome Lacoste (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-463?page=comments#action_40881 ]
     
Jerome Lacoste commented on MNG-463:
------------------------------------

Yes. m2-bootstrap-all.sh

The code that performs the delete is I think in MBoot.java

        [...]
        File dist = new File( mavenHome );
        System.out.println( "Maven installation directory: " + dist );
        [...]
        // build the installation
        FileUtils.deleteDirectory( dist );
        [...]


> [data loss] installation script inconditionally deletes M2_HOME contents
> ------------------------------------------------------------------------
>
>          Key: MNG-463
>          URL: http://jira.codehaus.org/browse/MNG-463
>      Project: Maven 2
>         Type: Improvement
>     Versions: 2.0-alpha-3
>     Reporter: Jerome Lacoste
>     Priority: Critical

>
>
> I've set up M2_HOME to a wrong directory by mistake, and the m2 installer deleted everything in it...
> May I suggest to use the same strategy used by the cargo installer?
> I.e. 
> if (target directory empty || m2 marker file exists)
> - copy the contents
> - add a marker file specific to m2
> else
>   warn user
> See CARGO-27 for the original CARGO issue.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-463) [data loss] installation script inconditionally deletes M2_HOME contents

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-463?page=comments#action_40877 ]
     
Brett Porter commented on MNG-463:
----------------------------------

what "installation script" are you referring to? The bootstrap, for doing a development build?


> [data loss] installation script inconditionally deletes M2_HOME contents
> ------------------------------------------------------------------------
>
>          Key: MNG-463
>          URL: http://jira.codehaus.org/browse/MNG-463
>      Project: Maven 2
>         Type: Improvement
>     Versions: 2.0-alpha-3
>     Reporter: Jerome Lacoste
>     Priority: Critical

>
>
> I've set up M2_HOME to a wrong directory by mistake, and the m2 installer deleted everything in it...
> May I suggest to use the same strategy used by the cargo installer?
> I.e. 
> if (target directory empty || m2 marker file exists)
> - copy the contents
> - add a marker file specific to m2
> else
>   warn user
> See CARGO-27 for the original CARGO issue.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MNG-463) [data loss] installation script inconditionally deletes M2_HOME contents

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-463?page=all ]
     
Brett Porter closed MNG-463:
----------------------------

    Resolution: Fixed

> [data loss] installation script inconditionally deletes M2_HOME contents
> ------------------------------------------------------------------------
>
>          Key: MNG-463
>          URL: http://jira.codehaus.org/browse/MNG-463
>      Project: Maven 2
>         Type: Improvement
>     Versions: 2.0-alpha-3
>     Reporter: Jerome Lacoste
>     Priority: Critical

>
>
> I've set up M2_HOME to a wrong directory by mistake, and the m2 installer deleted everything in it...
> May I suggest to use the same strategy used by the cargo installer?
> I.e. 
> if (target directory empty || m2 marker file exists)
> - copy the contents
> - add a marker file specific to m2
> else
>   warn user
> See CARGO-27 for the original CARGO issue.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org