(spark-kubernetes-operator) branch main updated: [SPARK-56445] Exclude unused `LoosePackageCoupling` PMD rule

[do...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/spark-kubernetes-operator.git


The following commit(s) were added to refs/heads/main by this push:
     new 9d8105d  [SPARK-56445] Exclude unused `LoosePackageCoupling` PMD rule
9d8105d is described below

commit 9d8105dedab3a072278665ea5d26997932caeb40
Author: Dongjoon Hyun <do...@apache.org>
AuthorDate: Fri Apr 10 11:50:37 2026 -0700

    [SPARK-56445] Exclude unused `LoosePackageCoupling` PMD rule
    
    ### What changes were proposed in this pull request?
    
    This PR excludes the unused `LoosePackageCoupling` rule from the PMD `category/java/design.xml` ruleset in `config/pmd/ruleset.xml` in order to suppress misleading warnings.
    
    ### Why are the changes needed?
    
    The `LoosePackageCoupling` rule requires explicit `packages` properties to be configured to be meaningful, and without that configuration it does not provide value for this project. Excluding it keeps the PMD ruleset consistent with the other `design` category exclusions.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No behavior change.
    
    ### How was this patch tested?
    
    Pass the CIs.
    
    **BEFORE**
    ```
    $ gradle :spark-operator-api:pmdTest
    ...
    > Task :spark-operator-api:pmdTest
    Removed misconfigured rule: LoosePackageCoupling cause: No packages or classes specified
    
    [Incubating] Problems report is available at: file:///Users/dongjoon/APACHE/spark-kubernetes-operator/build/reports/problems/problems-report.html
    
    BUILD SUCCESSFUL in 9s
    5 actionable tasks: 5 executed
    Configuration cache entry stored.
    ```
    
    **AFTER**
    ```
    $ gradle :spark-operator-api:pmdTest
    Starting a Gradle Daemon, 5 stopped Daemons could not be reused, use --status for details
    Calculating task graph as no cached configuration is available for tasks: :spark-operator-api:pmdTest
    
    > Configure project :build-tools-docs-utils
    Doc generated at build/config_properties.md
    WARNING: A terminally deprecated method in sun.misc.Unsafe has been called
    WARNING: sun.misc.Unsafe::objectFieldOffset has been called by lombok.permit.Permit
    WARNING: Please consider reporting this to the maintainers of class lombok.permit.Permit
    WARNING: sun.misc.Unsafe::objectFieldOffset will be removed in a future release
    
    > Task :spark-operator-api:compileTestJava
    warning: unknown enum constant Type.STRING
      reason: class file for io.fabric8.crd.generator.annotation.AdditionalPrinterColumn$Type not found
    warning: unknown enum constant Type.DATE
    2 warnings
    
    > Task :spark-operator-api:generateCrds
    Property 'stateTransitionHistory' with '[simple type, class java.lang.Long]' key type is mapped to 'string' because of CRD schemas limitations
    Property 'stateTransitionHistory' with '[simple type, class java.lang.Long]' key type is mapped to 'string' because of CRD schemas limitations
    Property 'stateTransitionHistory' with '[simple type, class java.lang.Long]' key type is mapped to 'string' because of CRD schemas limitations
    Property 'stateTransitionHistory' with '[simple type, class java.lang.Long]' key type is mapped to 'string' because of CRD schemas limitations
    Property 'stateTransitionHistory' with '[simple type, class java.lang.Long]' key type is mapped to 'string' because of CRD schemas limitations
    Property 'stateTransitionHistory' with '[simple type, class java.lang.Long]' key type is mapped to 'string' because of CRD schemas limitations
    Generated CRD sparkclusters.spark.apache.org:
      v1 -> /Users/dongjoon/APACHE/spark-kubernetes-operator/.claude/worktrees/recursing-khayyam/spark-operator-api/build/resources/main/sparkclusters.spark.apache.org-v1.yml
    Generated CRD sparkapplications.spark.apache.org:
      v1 -> /Users/dongjoon/APACHE/spark-kubernetes-operator/.claude/worktrees/recursing-khayyam/spark-operator-api/build/resources/main/sparkapplications.spark.apache.org-v1.yml
    
    [Incubating] Problems report is available at: file:///Users/dongjoon/APACHE/spark-kubernetes-operator/.claude/worktrees/recursing-khayyam/build/reports/problems/problems-report.html
    
    BUILD SUCCESSFUL in 9s
    5 actionable tasks: 5 executed
    Configuration cache entry stored.
    ```
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    Generated-by: Claude Code
    
    Closes #633 from dongjoon-hyun/SPARK-56445.
    
    Authored-by: Dongjoon Hyun <do...@apache.org>
    Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
 config/pmd/ruleset.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/config/pmd/ruleset.xml b/config/pmd/ruleset.xml
index 40cb52d..87ac868 100644
--- a/config/pmd/ruleset.xml
+++ b/config/pmd/ruleset.xml
@@ -51,6 +51,7 @@
     <exclude name="CyclomaticComplexity" />
     <exclude name="ExcessiveImports" />
     <exclude name="LawOfDemeter" />
+    <exclude name="LoosePackageCoupling" />
     <exclude name="NPathComplexity" />
     <exclude name="TooManyMethods" />
   </rule>


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org